Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add link to help repo in README #8570

Closed
wants to merge 2 commits into from
Closed

doc: add link to help repo in README #8570

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Sep 17, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

@Trott Trott added the doc Issues and PRs related to the documentations. label Sep 17, 2016
cjihrig
cjihrig approved these changes Sep 17, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

not-an-aardvark
not-an-aardvark reviewed Sep 17, 2016
View reviewed changes
README.md
@@ -386,6 +387,7 @@ keys:

[Website]: https://nodejs.org/en/
[Contributing to the project]: CONTRIBUTING.md
[Node.js Help]: http://github.com/nodejs/help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: https

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my, yes, HTTPS everywhere please. Fixed. Thanks.

@not-an-aardvark
Copy link
Contributor

LGTM with a nit

lpinca
lpinca approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ChALkeR
ChALkeR approved these changes Sep 17, 2016
View reviewed changes
Copy link
Member

@ChALkeR ChALkeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a squash.

@ChALkeR
Copy link
Member

ChALkeR commented Sep 17, 2016

This needs some description in the commit message, though.

@lpinca
Copy link
Member

lpinca commented Sep 19, 2016

@ChALkeR I find the commit subject line sufficient, what would you add in the description?

Trott added a commit to Trott/io.js that referenced this pull request Sep 20, 2016
@Trott
doc: add link to help repo in README
7c3ab1d 
Include link to Node.js help repo (for end user questions on how to use
Node.js) in the README.

PR-URL: nodejs#8570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@Trott
Copy link
Member Author

Trott commented Sep 20, 2016

Landed in 7c3ab1d. (I added a sentence to the body of the commit message before landing.)

@Trott Trott closed this Sep 20, 2016
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@Trott
doc: add link to help repo in README
fe0dc7c 
Include link to Node.js help repo (for end user questions on how to use
Node.js) in the README.

PR-URL: #8570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott
doc: add link to help repo in README
fbf54ca 
Include link to Node.js help repo (for end user questions on how to use
Node.js) in the README.

PR-URL: #8570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@Trott @Fishrock123
doc: add link to help repo in README
42386d7 
Include link to Node.js help repo (for end user questions on how to use
Node.js) in the README.

PR-URL: #8570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
doc: add link to help repo in README
a206e7a 
Include link to Node.js help repo (for end user questions on how to use
Node.js) in the README.

PR-URL: #8570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
doc: add link to help repo in README
64c4bb3 
Include link to Node.js help repo (for end user questions on how to use
Node.js) in the README.

PR-URL: #8570
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the help branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@not-an-aardvark not-an-aardvark not-an-aardvark left review comments

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@ChALkeR ChALkeR ChALkeR approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @not-an-aardvark @ChALkeR @lpinca @benjamingr @cjihrig @MylesBorins