Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: favor strict equality in test-exec #8173

Closed
wants to merge 1 commit into from
Closed

test: favor strict equality in test-exec #8173

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 18, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test child_process

Description of change

@Trott Trott added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. labels Aug 18, 2016
@jasnell
Copy link
Member

jasnell commented Aug 18, 2016

LGTM

2 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Aug 18, 2016

LGTM

@targos
Copy link
Member

targos commented Aug 19, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Aug 19, 2016

CI https://ci.nodejs.org/job/node-test-pull-request/3754/

Trott added a commit to Trott/io.js that referenced this pull request Aug 21, 2016
@Trott
test: favor strict equality in test-exec
9604d29 
PR-URL: nodejs#8173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 21, 2016

Landed in 9604d29

@Trott Trott closed this Aug 21, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@Trott @evanlucas
test: favor strict equality in test-exec
cfbafd7 
PR-URL: #8173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott
test: favor strict equality in test-exec
7ca1fcd 
PR-URL: #8173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: favor strict equality in test-exec
9bfe119 
PR-URL: #8173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: favor strict equality in test-exec
2997b79 
PR-URL: #8173
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the test-exec branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Trott @jasnell @cjihrig @targos @MylesBorins