Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: favor strict equality in test-exec #8173

Closed
wants to merge 1 commit into from
Closed

test: favor strict equality in test-exec #8173

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions test/pummel/test-exec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ exec(
console.log('error!: ' + err.code);
console.log('stdout: ' + JSON.stringify(stdout));
console.log('stderr: ' + JSON.stringify(stderr));
assert.equal(false, err.killed);
assert.strictEqual(false, err.killed);
} else {
success_count++;
console.dir(stdout);
Expand All @@ -38,17 +38,19 @@ exec(
exec('thisisnotavalidcommand', function(err, stdout, stderr) {
if (err) {
error_count++;
assert.equal('', stdout);
assert.equal(true, err.code != 0);
assert.equal(false, err.killed);
assert.strictEqual('', stdout);
assert.strictEqual(typeof err.code, 'number');
assert.notStrictEqual(err.code, 0);
assert.strictEqual(false, err.killed);
assert.strictEqual(null, err.signal);
console.log('error code: ' + err.code);
console.log('stdout: ' + JSON.stringify(stdout));
console.log('stderr: ' + JSON.stringify(stderr));
} else {
success_count++;
console.dir(stdout);
assert.equal(true, stdout != '');
assert.strictEqual(typeof stdout, 'string');
assert.notStrictEqual(stdout, '');
}
});

Expand All @@ -60,7 +62,7 @@ exec(SLEEP3_COMMAND, { timeout: 50 }, function(err, stdout, stderr) {
assert.ok(diff < 500);
assert.ok(err);
assert.ok(err.killed);
assert.equal(err.signal, 'SIGTERM');
assert.strictEqual(err.signal, 'SIGTERM');
});


Expand All @@ -71,7 +73,7 @@ process.nextTick(function() {
console.log('kill pid %d', killMeTwice.pid);
// make sure there is no race condition in starting the process
// the PID SHOULD exist directly following the exec() call.
assert.equal('number', typeof killMeTwice._handle.pid);
assert.strictEqual('number', typeof killMeTwice._handle.pid);
// Kill the process
killMeTwice.kill();
});
Expand All @@ -82,7 +84,7 @@ function killMeTwiceCallback(err, stdout, stderr) {
// works and that we are getting the proper callback parameters.
assert.ok(err);
assert.ok(err.killed);
assert.equal(err.signal, 'SIGTERM');
assert.strictEqual(err.signal, 'SIGTERM');

// the timeout should still be in effect
console.log('\'sleep 3\' was already killed. Took %d ms', diff);
Expand All @@ -98,6 +100,6 @@ exec('python -c "print 200000*\'C\'"', {maxBuffer: 1000},


process.on('exit', function() {
assert.equal(1, success_count);
assert.equal(1, error_count);
assert.strictEqual(1, success_count);
assert.strictEqual(1, error_count);
});