Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: mark pseudo-tty/no_dropped_stdio as flaky #8385

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Sep 2, 2016

  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

pseudo-tty

Description of change

We've determined there is a test issue related to python as
opposed to node, mark as flaky until we an resolve

We've determined there is a test issue related to python as
opposed to node, mark as flaky until we an resolve
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 2, 2016
@cjihrig
Copy link
Contributor

cjihrig commented Sep 2, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented Sep 2, 2016

LGTM

@mscdex mscdex added the process Issues and PRs related to the process subsystem. label Sep 2, 2016
@mhdawson mhdawson self-assigned this Sep 2, 2016
@Fishrock123
Copy link
Contributor

LGTM

@mhdawson
Copy link
Member Author

mhdawson commented Sep 6, 2016

Landed as 1ffdee7

@mhdawson mhdawson closed this Sep 6, 2016
mhdawson added a commit that referenced this pull request Sep 6, 2016
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: nodejs#8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
We've determined there is a test issue related to python as
opposed to node, mark as flaky until we can resolve

PR-URL: #8385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@mhdawson mhdawson deleted the pseudo-tty branch March 15, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process Issues and PRs related to the process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants