-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Harmony enabled binary, packages. #90
Comments
You can bake extra V8 options into the binary with See nodejs/node-v0.x-archive#6999, that's a trial PR I opened to get the discussion going. The conclusion was that --harmony features are generally half-baked (if not outright buggy) and that it's generally better to let them mature until they are no longer behind a flag. Generators and promises are examples of that.
--noharmony should work. |
A completely different way to approach this -- to declare a dependency on a harmony supporting binary -- is to bring that binary in yourself:
Then Not exactly what you're asking, but has some of the same effects: declare what you're doing, and make it Just Work. |
Hello! I am pleased to see your valuable contribution to this project. Would you Questions:
Please provide the answers in an ordered list like this:
Note that I am just a bot with a limited human-reply parsing abilities, In case of success I will say: In case of validation problem I will say: Truly yours, Responsibilities
|
Closing based on @bnoordhuis response. |
@bnoordhuis since V8 has introduced an |
do we have a catalogue of what |
@rvagg: yes - on master (3.31.x) and on 3.30.37. |
@ruimarinho Close but no cigar. :-) In V8 3.30 (what currently ships with io.js), I personally don't really object to turning on |
@bnoordhuis ah, yes, just noticed that there was an update on that. Seems like Looking back at node 0.11.14 (V8 3.26.33), the only feature under staging was |
PR-URL: nodejs/node-chakracore#93 Reviewed-By: Jianchun Xu <Jianchun.Xu@microsoft.com> Fixes: nodejs#90
* napi: Separate API for external ArrayBuffer
Greetings.
Some of us really want nothing to do with the old ES5 world and are wanting to make a clean hard break. I would like to see a node binary where harmony is the default. This could be a configuration variable at build time, it could be a node-harmony binary, or perhaps we're ready to throw the switch and just do it for everyone: something to avoid the sys-administration of wrapper shell scripts or project configuration needed to add
--harmony
.For responsibility/compatibility sake, npm packages need some what to discern the target:
engines
might stand to have aharmony
target that designates that a harmony targeting engine is needed.Follow-up item: whether it's desirable or needed to have a
--disharmony
.The text was updated successfully, but these errors were encountered: