Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: make WHATWG URL properties spec compliant #10408

Closed
wants to merge 2 commits into from
Closed

url: make WHATWG URL properties spec compliant #10408

wants to merge 2 commits into from

Commits on Dec 29, 2016

  1. benchmark: add benchmark for WHATWG URL properties

    @joyeecheung
    joyeecheung committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    62d115f View commit details
    Browse the repository at this point in the history

  2. url: make WHATWG URL properties spec compliant 

    * Set exposed attributes of the interface enumerable
  and configurable, as required by the spec.
  See: https://heycam.github.io/webidl/#es-attributes
* Make sure `URL#searchParams` returns `[[SameObject]]`
* Add the missing `URL#href` setter
* Reorder the properties to match
  https://url.spec.whatwg.org/#api
* Add tests for the ECMAScript property attributes

Fixes: nodejs#10376
    @joyeecheung
    joyeecheung committed Dec 29, 2016
    Configuration menu
    Copy the full SHA
    126d6e7 View commit details
    Browse the repository at this point in the history