Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7.7.1 Proposal #11638

Merged
merged 9 commits into from
Mar 2, 2017
Merged

7.7.1 Proposal #11638

merged 9 commits into from
Mar 2, 2017

Commits on Mar 1, 2017

  1. tracing: fix -Wreorder warning 

    Initialize `InternalTraceBuffer::id_` the last.

PR-URL: #10416
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @santigimeno @italoacasas
    santigimeno authored and italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    8a918bf View commit details
    Browse the repository at this point in the history

  2. tracing: fix -Wunused-private-field warning 

    Remove `external_buffer_` from `InternalTraceBuffer` as it seems not to
be used anywhere.

PR-URL: #10416
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
    @santigimeno @italoacasas
    santigimeno authored and italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    3dc4a5f View commit details
    Browse the repository at this point in the history

  3. src: always initialize tracing controller in agent 

    PR-URL: #10507
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @italoacasas
    Matt Loring authored and italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    b89b2a7 View commit details
    Browse the repository at this point in the history

  4. src: fix TracingController cleanup 

    This fixes an incorrect deletion of the `TracingController` instance,
which in some environments could cause an error about an invalid
pointer passed to `free()`. The `TracingController` instance is
actually owned by a `unique_ptr` member of the platform, so calling
`platform::SetTracingController(nullptr)` is the correct way to
delete it. But before that, the `TraceBuffer` must be deleted in
order for the tracing loop to exit; that is accomplished by calling
`TracingController::Initialize(nullptr)`.

PR-URL: #10623
Reviewed-By: Matthew Loring <mattloring@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
    @jasongin @italoacasas
    jasongin authored and italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    30c80cb View commit details
    Browse the repository at this point in the history

  5. build: add missing src/tracing header files 

    I noticed that only one header from src/tracing is included in the
sources list in node.gyp. Not sure if this is intentional or not so I
wanted to bring it up just in case this was overlooked.

PR-URL: #10851
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
    @danbev @italoacasas
    danbev authored and italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    c8e34b6 View commit details
    Browse the repository at this point in the history

  6. src: move trace_event.h include to internal header 

    Move the include from src/node.h to src/node_internals.h.

trace_event.h is not shipped in binary-only and headers-only tarballs,
making it currently impossible to build add-ons against them.

PR-URL: #10959
Refs: nodejs/citgm#226 (comment)
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matthew Loring <mattloring@google.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
    @bnoordhuis @italoacasas
    bnoordhuis authored and italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    96f55f9 View commit details
    Browse the repository at this point in the history

  7. test: increase strictness for test-trace-event 

    Change test-trace-event such that it checks that all expected values are
within the same trace object rather than scattered across multiple trace
objects.

PR-URL: #11065
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
    @Trott @italoacasas
    Trott authored and italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    7b253eb View commit details
    Browse the repository at this point in the history

  8. test: make test-intl-no-icu-data more robust 

    In V8 5.6, String#toLocaleUpperCase can work even when no ICU data is
loaded. Use another method to check the --icu-data-dir option pointing
to an empty directory.

PR-URL: #10992
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @targos @italoacasas
    targos authored and italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    54e55e0 View commit details
    Browse the repository at this point in the history

  9. 2017-03-01, Version 7.7.1 (Current) 

    Notable changes:

Node.js 7.7.0 contains a bug that will prevent all native modules
from building, this patch should fix the issue. Apologies to
everyone who was affected by 7.7.0.

PR-URL: #11638
    @italoacasas
    italoacasas committed Mar 1, 2017
    Configuration menu
    Copy the full SHA
    5c2e415 View commit details
    Browse the repository at this point in the history