-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: test resolveObject with an empty path #11811
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a case to test an URL object that has no path at all for `url.resolveObject`.
watilde
force-pushed
the
feature/test-url-no-path
branch
from
March 12, 2017 14:03
9e63110
to
069fa16
Compare
watilde
changed the title
url: test resolveObject with an empty path
test: test resolveObject with an empty path
Mar 12, 2017
Updated the name of a subsystem to |
cjihrig
approved these changes
Mar 12, 2017
joyeecheung
approved these changes
Mar 12, 2017
jasnell
approved these changes
Mar 13, 2017
Same with this: #11812 (comment). I will rerun the CI. |
hiroppy
approved these changes
Mar 13, 2017
Landed in 92bcc13 |
watilde
added a commit
that referenced
this pull request
Mar 14, 2017
Add a case to test an URL object that has no path at all for `url.resolveObject`. PR-URL: #11811 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 20, 2017
Add a case to test an URL object that has no path at all for `url.resolveObject`. PR-URL: nodejs#11811 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
Add a case to test an URL object that has no path at all for `url.resolveObject`. PR-URL: nodejs#11811 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a case to test an URL object that has no path at all for
url.resolveObject
.This test increases the coverage of
lib/url.js
:The following lines will be checked:
node/lib/url.js
Lines 846 to 849 in 055482c
node/lib/url.js
Lines 853 to 858 in 055482c
This PR was part of #11395 that I created, and I separated a non-breaking change commit from #11395 to this PR. I will update #11395 later.
Checklist
make -j4 test
Affected core subsystem(s)
test