v7.7.4 Release Proposal #11941
Merged
v7.7.4 Release Proposal #11941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed or fixed use of arguments in execFile(), normalizeExecArgs(), and normalizeSpawnArguments(). Refs: #10323 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=6010 Backport-Of: #11535 PR-URL: #11748 Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #11582 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
TLSWrap object keeps a pointer reference to the underlying TCPWrap object. This TCPWrap object could be closed and deleted by the event-loop which leaves us with a dangling pointer. So the TLSWrap object needs to track the "close" event on the TCPWrap object. PR-URL: #11776 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
PR-URL: #11582 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Previously when the child dies with errors in this test, the parent will just hang and timeout, the errors in the child would be swallowed. This makes it fail so at least there is more information about why this test fails. Also removes the unnecessary child.kill() call. PR-URL: #11684 Ref: #11667 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Make sure test matches this specific error message. PR-URL: #11815 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
`test/known_issues/test-repl-function-redefinition-edge-case.js` had been introduced as a part of #7624 but the meat of the test became fixed in 007386e. Despite that, the test continued to fail since it was broken itself: there was a missing colon in the expected output. This commit adds the missing colon and moves the test from `test/known_issues` to `test/parallel`. PR-URL: #11772 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add a case to test an URL object that has no path at all for `url.resolveObject`. PR-URL: #11811 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Currently, indexed properties are correctly copied onto the sandbox by CopyProperties(). This will break when CopyProperties() is removed after adjusting NamedPropertyHandlerConfiguration config() to use property callbacks from the new V8 API. To fix it, we will set a config for indexed properties. This test is a preparation step for the patch that removes CopyProperties(). PR-URL: #11769 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
test-domain-abort-on-uncaught is flaky under load. Move it to sequential so it is not competing with other tests for resources. PR-URL: #11817 Fixes: #11814 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The tests in pseudo-tty takes the form of child node writing some data and exiting, while parent python consume them through pseudo tty implementations, and validate the result. While there is no synchronization between child and parent, this works for most platforms, except AIX, where the child exits even before the parent could setup the read loop, under race conditions Fixing the race condition is ideally done through sending ACK messages to and forth, but involves massive changes and have side effect. The workaround is to address them in AIX alone, by adding a reasonable delay. PR-URL: #11715 Fixes: #7973 Fixes: #9765 Fixes: #11541 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
CopyProperties() causes sandboxed Proxy to throw error when in fact no code has been run. The function will be removed with the updates to the V8 API. Here, failing Proxy test case is moved to known_issues. PR-URL: #11671 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Make sure that monkey-patching process.execArgv doesn't cause child_process to incorrectly munge execArgv in fork(). This basically is adding coverage for an `index > 0` check (see Refs). Previously, that condition was never false in any of the tests. PR-URL: #11800 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Refs: https://github.com/nodejs/node/blob/c67207731f16a78f6cae90e49c53b10728241ecf/lib/child_process.js#L76
Prototypes are not strict equal when they are from different contexts. Therefore, assert.strictEqual() fails for objects that are created in different contexts, e.g., in vm.runInContext(). Instead of expecting the prototypes to be equal, only check the properties of the objects for equality. PR-URL: #11862 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #11582 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #11582 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Remove a comment disabling an ESLint rule that is not triggered by the code anyway. PR-URL: #11836 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #11582 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #11582 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #11582 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Add duplicate symbol checking in E() to avoid potential confusing result. Increase coverage of internal/errors. PR-URL: #11829 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Removed the msg parameter in the Client function of _debug_agent.js, because it is unused. PR-URL: #11833 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
PR-URL: #11869 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #11810 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #11810 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fix comment about remove listener (not setting) PR-URL: #11804 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Fix a mistyped module name in example REPL sessions found in the description of the 'warning' event: it should be `events` instead of `event`. PR-URL: #11780 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot
added
doc
italoacasas
removed
build
Original commit message: Trigger OOM crash if no memory returned in v8::ArrayBuffer::New and v… …8::SharedArrayBuffer::New. This API does not allow reporting failure, but we should crash rather than have the caller get an ArrayBuffer that isn't properly set up. BUG=chromium:681843 Review-Url: https://codereview.chromium.org/2641953002 Cr-Commit-Position: refs/heads/master@{#42511}
Due to changes in V8, the debug protocol will no longer work in Node.js 8.0.0. Note this in the documentation. PR-URL: #10320 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Adding documentation to node.1 and cli.md PR-URL: #11660 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@nodejs/streams someone knows what happend here? cc: @nodejs/citgm |
|
@MylesBorins can you let me know if the CITGM results are ok. @italoacasas is ill and has asked me to finish the release. |
|
@italoacasas we ported some more unit tests from core. This is the offending line https://github.com/nodejs/readable-stream/blob/7af74b040213486d9c76ef41931011a2a4859119/test/common.js#L45. I think the box running citgm is setting |
Should be: |
cjihrig
force-pushed
the
v7.7.4-proposal
branch
from
f65818e
to
44b4c0b
Compare
|
I may be able to write a changelog after lunch, if desired. |
### Notable Changes
* **inspector**: Upgraded internal node-inspect version to 1.10.6, containing several fixes. (Jan Krems) [#11869](https://github.com/nodejs/node/pull/11869)
* **lib**: Removed the internal use of `forEach` from 8 subsystems in favor of faster alternatives. (James M Snell) [#11582](https://github.com/nodejs/node/pull/11582)
* **tls**: Fixed a segfault when the handle was destroyed after a partial read. (Ben Noordhuis) [#11898](https://github.com/nodejs/node/pull/11898)Maybe I glossed over the inspector changes a bit too much, not sure. |
|
@Fishrock123 thanks for writing that up. I've already started the build. Only the pi1 is still building, and I'm not going to start a new build, just to make that update. Is it OK to just amend the release commit, which hasn't been tagged yet? If so, I'll do that. Otherwise, I could use your text on the blog post. |
|
@cjihrig It is ok to modify if it is untagged but you need to sign it off a tagged build so you probably need to rebuild? I'm not quite sure. |
|
OK, I'm just going to use it on the blog to be safe. That Pi build takes too long :-) |
PR-URL: #11941
cjihrig
added a commit
that referenced
this pull request
Mar 21, 2017
cjihrig
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Mar 21, 2017
imyller
added a commit
to imyller/meta-nodejs
that referenced
this pull request
Apr 20, 2017
Notable changes:
* deps: Add node-inspect 1.10.6 (Jan Krems) nodejs/node#11869
* inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) nodejs/node#11850
* tls: fix segfault on destroy after partial read. (Ben Noordhuis) nodejs/node#11898
PR-URL: nodejs/node#11941
Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-03-21, Version 7.7.4 (Current), @cjihrig
Not landing right now:
https://gist.github.com/italoacasas/d3212151d158a8a7792e76b5e1efd38c
Notable changes
// comming soon
CI
Commits
f48763c5b9] - benchmark: remove benchmarks forced optimizations (Bartosz Sosnowski)dcac2d8f04] - benchmark: benchmark comparing forEach with for (James M Snell) #1158280949f3d88] - build: add cpp linting to windows build (liusi) #118565244ee346b] - build: mac OBJ_DIR should point to obj.target (Daniel Bevenius) #118575b1d61ce09] - child_process: fix deoptimizing use of arguments (Vse Mozhet Byt) #11748ca319862fd] - deps: cherry-pick ca0f9573 from V8 upstream (Ali Ijaz Sheikh)a7e4b029da] - deps: Add node-inspect 1.10.6 (Jan Krems) #118690c00b655d8] - doc: Fix cli help documentation for --inspect #7065: cli help documentation for --inspect (Noj Vek) #1166060ad7af65e] - doc: deprecate debug protocol (Jan Krems) #10320a5f7393541] - doc: add vsemozhetbyt to collaborators (Vse Mozhet Byt) #119320c091262bd] - doc: add note that vm module is not a security mechanism (Ruslan Bekenev) #115576d6a65e2ad] - doc: linkable commit message guidelines (Sam Roberts) #117927c7228ed4b] - doc: gcc version is at least 4.8.5 in BUILDING.md (detailyang) #118409861ec93d4] - doc: increase Buffer.concat() documentation (cjihrig) #1184554879ab7d1] - doc: fix mistakes in stream doc (object mode) (Christian d'Heureuse) #1180778ca15dd78] - doc: argument types for dns methods (Amelia Clarke) #11764e84e33c87c] - doc: fix a typo in api/process.md (Gaara) #1178075fcf53173] - doc: missing argument types for events methods (Amelia Clarke) #11802ae52b63df2] - doc: correct comment error in stream.md (Alexander) #11804e6f113d3d5] - doc: console.log() -> console.error() in events.md (Vse Mozhet Byt) #11810cde5d71db1] - doc: var -> let / const in events.md (Vse Mozhet Byt) #11810d0fb578d64] - fs: avoid using forEach (James M Snell) #1158214e3ad0c5e] - inspector: proper WS URLs when bound to 0.0.0.0 (Eugene Ostroukhov) #11850fbbcd1aa89] - lib: Fix swallowed events in inspect integration (Jan Krems) #118699cc712ca18] - lib: remove unused msg parameter in debug_agent (mr-spd) #1183377c69f7ace] - lib, test: add duplicate symbol checking in E() (DavidCai) #118297e230727fc] - module: avoid using forEach (James M Snell) #11582c0a2e02f51] - net: avoid using forEach (James M Snell) #11582a0b1aa1161] - readline: avoid using forEach (James M Snell) #11582e19ca8ba11] - readline: remove unneeded eslint-disable comment (Rich Trott) #1183662e726109a] - repl: avoid using forEach (James M Snell) #1158290be5a1f19] - stream: avoid using forEach (James M Snell) #115822cab00aec0] - test: fix assertion in vm test (AnnaMag) #118628bda7b8d39] - test: add coverage for child_process bounds check (Rich Trott) #118003ae58acd29] - test: failing behaviour on sandboxed Proxy (AnnaMag) #11671560d8eed9a] - test: delay child exit in AIX for pseudo-tty tests (Gireesh Punathil) #11715f9c831f4b1] - test: fix flaky test-domain-abort-on-uncaught (Rich Trott) #118172649dab274] - test: added test for indexed properties (AnnaMag) #117692df662c95a] - test: test resolveObject with an empty path (Daijiro Wachi) #11811d2c9111614] - test: fix repl-function-redefinition-edge-case (Alexey Orlenko) #11772c9cf922248] - test: add regex to assert.throws (Matej Krajčovič) #118155f6025ba68] - test: fail when child dies in fork-net (Joyee Cheung) #11684c626734409] - tls: fix segfault on destroy after partial read (Ben Noordhuis) #11898646ee559df] - tls: avoid using forEach (James M Snell) #11582540830116b] - tls: keep track of stream that is closed (jBarz) #117769a59913039] - util: avoid using forEach (James M Snell) #11582