Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: removed unused msg parameter in debug_agent #11833

Closed
wants to merge 1 commit into from
Closed

lib: removed unused msg parameter in debug_agent #11833

wants to merge 1 commit into from

Conversation

mr-spd
Copy link
Contributor

@mr-spd mr-spd commented Mar 13, 2017

Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

lib

@gibfahn
Copy link
Member

gibfahn commented Mar 13, 2017

Minor nit: could you change removed->remove in the commit message?

See the Contributing Guidelines for more info.

Someone can do this on landing if you don't have time.

@mr-spd
lib: remove unused msg parameter in debug_agent
068c8b4 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.
@mr-spd mr-spd force-pushed the unused_parameter branch from 37384a5 to 068c8b4 Compare March 13, 2017 19:19
gibfahn
gibfahn approved these changes Mar 13, 2017
View reviewed changes
Copy link
Member

@gibfahn gibfahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@JacksonTian
Copy link
Contributor

LGTM

@hiroppy
Copy link
Member

hiroppy commented Mar 14, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6831/

@fhinkel
Copy link
Member

fhinkel commented Mar 15, 2017 •
edited by gibfahn
Loading

Thanks. Landed in 5bd1642

@fhinkel fhinkel closed this Mar 15, 2017
fhinkel pushed a commit that referenced this pull request Mar 15, 2017
@mr-spd @fhinkel
lib: remove unused msg parameter in debug_agent
5bd1642 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
@mr-spd @italoacasas
lib: remove unused msg parameter in debug_agent
9cc712c 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs#11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
@italoacasas italoacasas mentioned this pull request Mar 20, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@mr-spd @jungx098
lib: remove unused msg parameter in debug_agent
f1ebeed 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs#11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@mr-spd @MylesBorins
lib: remove unused msg parameter in debug_agent
8068d3f 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@mr-spd @MylesBorins
lib: remove unused msg parameter in debug_agent
f8426d9 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: #11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@mr-spd @andrew749
lib: remove unused msg parameter in debug_agent
453f1b3 
Removed the msg parameter in the Client function
of _debug_agent.js, because it is unused.

PR-URL: nodejs/node#11833
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
This was referenced Mar 7, 2020
Open
Open
Open
Open
Open
Open
@adamlaska adamlaska mentioned this pull request Nov 30, 2023
Open
@aliscco aliscco mentioned this pull request Dec 1, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 1, 2023
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
This was referenced Dec 1, 2023
Open
Open
@adamlaska adamlaska mentioned this pull request Dec 2, 2023
Open
@aliscco aliscco mentioned this pull request Dec 2, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
Open
Open
@leonardoadame leonardoadame mentioned this pull request Dec 2, 2023
Open
This was referenced Dec 2, 2023
Open
Open
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 2, 2023
Open
Open
This was referenced Dec 3, 2023
Open
Open
Open
@aliscco aliscco mentioned this pull request Dec 3, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 3, 2023
Open
@aliscco aliscco mentioned this pull request Dec 3, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Dec 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

@danbev danbev danbev approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@mr-spd @gibfahn @JacksonTian @hiroppy @fhinkel @danbev @jasnell @cjihrig @MylesBorins @nodejs-github-bot