Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix flaky test-domain-abort-on-uncaught #11817

Closed
wants to merge 1 commit into from
Closed

test: fix flaky test-domain-abort-on-uncaught #11817

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 12, 2017

test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

Fixes: #11814

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test domain

@Trott Trott added domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests. labels Mar 12, 2017
@Trott
test: fix flaky test-domain-abort-on-uncaught
8af27d5 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

Fixes: nodejs#11814
@Trott Trott force-pushed the flaky-domain-test branch from 862b69e to 8af27d5 Compare March 12, 2017 16:14
@Trott Trott changed the title test: move flaky test to sequential test: fix flaky test-domain-abort-on-uncaught Mar 12, 2017
@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/6809/

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

Stress test of master (should show failures): https://ci.nodejs.org/job/node-stress-single-test/1119/nodes=armv8-ubuntu1404/console

Stress test of this PR (should be green): https://ci.nodejs.org/job/node-stress-single-test/1120/nodes=armv7-ubuntu1404/console

@Trott Trott mentioned this pull request Mar 12, 2017
Closed
@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

Whoops, ran the initial stress test on the wrong architecture.

Stress test again on master (should show failures): https://ci.nodejs.org/job/node-stress-single-test/1122/nodes=armv7-ubuntu1404/console

Stress test on this PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1123/nodes=armv7-ubuntu1404/console

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

Amping up the stress test a bit more to 16 parallel processes.

Master (should fail): https://ci.nodejs.org/job/node-stress-single-test/1127/nodes=armv7-ubuntu1404/console

This PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1128/nodes=armv7-ubuntu1404/console

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

Amping up the stress test a bit more to 32 parallel processes.

Master (should fail): https://ci.nodejs.org/job/node-stress-single-test/1129/nodes=armv7-ubuntu1404/console

This PR (should succeed): https://ci.nodejs.org/job/node-stress-single-test/1130/nodes=armv7-ubuntu1404/console

@Trott
Copy link
Member Author

Trott commented Mar 12, 2017

(Current master is failing the stress test, this PR is passing it.)

@gibfahn gibfahn mentioned this pull request Mar 13, 2017
Closed
@Trott Trott closed this Mar 13, 2017
@Trott Trott reopened this Mar 13, 2017
@watilde watilde mentioned this pull request Mar 13, 2017
Closed
2 tasks
@jasnell
Copy link
Member

jasnell commented Mar 15, 2017

New CI since there was a failure on Windows: https://ci.nodejs.org/job/node-test-pull-request/6844/

jasnell pushed a commit that referenced this pull request Mar 16, 2017
@Trott @jasnell
test: fix flaky test-domain-abort-on-uncaught
5e3d536 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Mar 16, 2017

Landed in 5e3d536

@jasnell jasnell closed this Mar 16, 2017
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 20, 2017
@Trott @italoacasas
test: fix flaky test-domain-abort-on-uncaught
f9c831f 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs#11817
Fixes: nodejs#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Mar 20, 2017
Merged
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@Trott @jungx098
test: fix flaky test-domain-abort-on-uncaught
87502dd 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs#11817
Fixes: nodejs#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 18, 2017
@Trott @MylesBorins
test: fix flaky test-domain-abort-on-uncaught
d11fd98 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
@Trott @MylesBorins
test: fix flaky test-domain-abort-on-uncaught
72710d0 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: #11817
Fixes: #11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 19, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@Trott @andrew749
test: fix flaky test-domain-abort-on-uncaught
79da204 
test-domain-abort-on-uncaught is flaky under load. Move it to sequential
so it is not competing with other tests for resources.

PR-URL: nodejs/node#11817
Fixes: nodejs/node#11814
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott deleted the flaky-domain-test branch January 13, 2022 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gibfahn gibfahn gibfahn approved these changes

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@watilde watilde watilde approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
domain Issues and PRs related to the domain subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

investigate flaky test-domain-abort-on-uncaught
8 participants
@Trott @jasnell @santigimeno @watilde @cjihrig @hiroppy @gibfahn @MylesBorins