Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v7.x-backport) build: enable cctest to use generated objects #12321

Closed
wants to merge 2 commits into from

Conversation

aqrln
Copy link
Contributor

@aqrln aqrln commented Apr 11, 2017

Backport #11956 to v7.x. PRs #12042 and #12238 (both labeled as "backport-to-v7.x") depend on it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build, doc

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. dont-land-on-v4.x test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory. labels Apr 11, 2017
@aqrln
Copy link
Contributor Author

aqrln commented Apr 11, 2017

@aqrln
Copy link
Contributor Author

aqrln commented Apr 11, 2017

Current CI failures are nodejs/build#681, nodejs/build#682 and #12104 (comment).

@aqrln
Copy link
Contributor Author

aqrln commented Apr 11, 2017

New CI: https://ci.nodejs.org/job/node-test-pull-request/7340/

All seems to be good except for a known issue for v7.x-staging branch.

This commit tries to make it simpler to add unit tests (cctest) for
code that needs to test node core funtionality but that might not be
appropriate as an addon or a JavaScript test. An example of this could
be adding functionality targeted for situations when Node itself is
embedded.

Currently it was not as easy, or efficient, as one would have hoped to
add such tests. The object output directories vary for different
operating systems which we need to link to so that we don't have an
additional compilation step.

PR-URL: nodejs#11956
Ref: nodejs#9163
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#11956
Ref: nodejs#9163
Reviewed-By: James M Snell <jasnell@gmail.com>
@aqrln
Copy link
Contributor Author

aqrln commented Apr 12, 2017

Force-pushed with full original commit messages (no metadata removed).

Ref: nodejs/Release#191

Copy link
Contributor

@evanlucas evanlucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanlucas
Copy link
Contributor

Landed in 75f0855. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants