test: refactor test-tls-env-extra-ca #13886
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trott
added
test
hiroppy
approved these changes
Jun 23, 2017
benjamingr
approved these changes
Jun 23, 2017
richardlau
reviewed
Jun 23, 2017
|
|
||
| if (process.env.CHILD) { | ||
| const copts = { | ||
| port: process.env.PORT, | ||
| checkServerIdentity: common.noop, | ||
| checkServerIdentity: common.mustCall(), | ||
| }; | ||
| const client = tls.connect(copts, function() { |
There was a problem hiding this comment.
Should this be common.mustCall()?
There was a problem hiding this comment.
Also for tls.createServer() below.
There was a problem hiding this comment.
@richardlau Yes to both. Good catch. Added! Thanks.
richardlau
reviewed
Jun 23, 2017
| const tls = require('tls'); | ||
|
|
||
| const fork = require('child_process').fork; |
There was a problem hiding this comment.
Should this also be reordered?
There was a problem hiding this comment.
I put it separate from the rest because of the .fork appended to the end. I think our test writing guidelines might be ambiguous on this situation. ¯\(ツ)/¯
cjihrig
approved these changes
Jun 23, 2017
* Use `common.mustCall()` to guarantee callback invocations * Order modules according to test writing guide
Trott
force-pushed
the
refactor-test-tls-env-extra-ca
branch
from
3714d52
to
7552cc3
Compare
lpinca
approved these changes
Jun 23, 2017
richardlau
approved these changes
Jun 23, 2017
|
Landed in 062c414 |
Merged
Merged
This was referenced Sep 5, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
common.mustCall()to guarantee noop function is calledChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test tls