v6.11.3-proposal #14852
Merged
v6.11.3-proposal #14852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
root_cert_vector currently has file scope and external linkage, but is only used in the NewRootCertsStore function. If this is not required to be externally linked perhaps it can be changed to be static and function scoped instead. PR-URL: #12788 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org>
root_cert_store is defined as extern in node_crypto.h but only used in node_crypto.cc. It is then set using SSL_CTX_set_cert_store. The only usages of SSL_CTX_get_cert_store are in node_crypto.cc which would all be accessing the same X509_STORE through the root_cert_store pointer as far as I can tell. Am I missing something here? This commit suggests removing it from the header and making it static in node_crypto.cc. PR-URL: #13194 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Original commit messages: v8/v8@a2ab135 [snapshot] Rehash strings after deserialization. See https://goo.gl/6aN8xA Bug: v8:6593 Change-Id: Ic8b0b57195d01d41591397d5d45de3f0f3ebc3d9 Reviewed-on: https://chromium-review.googlesource.com/574527 Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#46732} v8/v8@182caaf Do not track transitions for built-in objects. Objects created during bootstrapping do not need a transition tree except for elements kind transitions. Bug: v8:6596 Change-Id: I237b8b2792f201336e1c9731c815095dd06bc182 Reviewed-on: https://chromium-review.googlesource.com/571750 Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#46693} Fixes: #14171 PR-URL: #14385
Unset `mode_` when initializing the zlib stream failed, so that we don’t try to call the zlib end functions (`deflateEnd()` etc.) when cleaning up in `ZCtx::Close()`. Fixes: #14178 Ref: #13098 PR-URL: #14666 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Export a new common.noop no-operation function for general use. Allow using common.mustCall() without a fn argument to simplify test cases. Replace various non-op functions throughout tests with common.noop PR-URL: #12027 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Prefer using `common.mustNotCall()` over `common.mustCall(fn, 0)` PR-URL: #12027 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #12935 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Fix the bug that you start process without network at first, but it connected lately, `dns.resolve` will stay failed with ECONNREFUSED because c-ares servers fallback to 127.0.0.1 at the very beginning. If c-ares servers "127.0.0.1" is detected and its not set by user self, and last query is not OK, recreating `ares_channel` operation will be triggered to reload servers. Fixes: #1644 Backport-PR-URL: #14434 PR-URL: #13076 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
A few of the CLI option values exposed as properties on the process object were missing a comment, fix this. Backport-PR-URL: #14483 PR-URL: #12245 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
bootstrap_node.js was directly parsing process.execArgv to see if internals should be exposed, even though the argv was already parsed by node. This is unusual and unnecessary, change it to set the option value from the parser onto the config binding. Backport-PR-URL: #14483 PR-URL: #12245 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Backport-PR-URL: #14787 PR-URL: #14438 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
As the length of `path` is known at this point, there is no point in making an exact copy using `slice`. Backport-PR-URL: #14787 PR-URL: #14438 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
* we use u_setDataDirectory() in "unicode/putil.h" * at present, this header is indirectly included, but this will change in ICU 59 * no impact on past ICUs. * this is an exact analog to #11753 PR-URL: #12078 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Timers should work even if the user has monkey-patched `.call()` and `.apply()` to undesirable values. PR-URL: #12960 Ref: #12956 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Original commit message:
This commit adds a getter for the private is_verbose_ member.
The use case for this comes from Node.js where the ability to avoid
calling FatalException if the TryCatch is verbose would be nice
to have.
BUG=
Review-Url: https://codereview.chromium.org/2840803002
Cr-Commit-Position: refs/heads/master@{#45018}
PR-URL: #12826
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit attempts to address the TODO regarding not calling FatalException if the try_catch is verbose. PR-URL: #12826 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
`configure` will now call `node_gyp` as a module instead of forking makes it easier to debug PR-URL: #12653 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
When a no-op message event handler is used in a test, make it clear what is expected by using `common.mustCall()` and `common.mustNotCall()`. PR-URL: #13125 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Use common.mustCall() in test-fs-makeStatsCallback to confirm that the callback is invoked. PR-URL: #13132 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <mhdawson@ibm.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
In test/pummel/test-stream2-basic.js, check that noop functions are called the expected number of times. PR-URL: #13146 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #13146 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
test-stream2-basic runs in a few seconds. It can be moved to parallel. PR-URL: #13146 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use the same dtrace command on ARM as on i386. Patch obtained from FreeBSD PR 218081 [1]. 1. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218081 PR-URL: #12193 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Use `common.mustNotCall()` in test-stream2-objects.js to confirm that noop function is never invoked. PR-URL: #13249 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #14286 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* test/parallel/test-stdout-close-catch.js PR-URL: #14298 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Based on discussion from the first backporting team meeting. PR-URL: #12431 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Original commit message:
ares_parse_naptr_reply: make buffer length check more accurate
9478908a490a6bf009ba58d81de8c1d06d50a117 introduced a length check
for records parsed by `ares_parse_naptr_reply()`. However, that
function is designed to parse replies which also contain non-NAPTR
records; for A records, the `rr_len > 7` check will fail as there
are only 4 bytes of payload.
In particular, parsing ANY replies for NAPTR records was broken
by that patch.
Fix that by moving the check into the case in which it is already
known that the record is a NAPTR record.
Ref: c-ares/c-ares@18ea996
PR-URL: #13883
Reviewed-By: James M Snell <jasnell@gmail.com>
* Update the experimental status to reflect actual common use. * Also make a few formatting fixes. Fixes: #12701 PR-URL: #12723 Fixes: #12701 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
PR-URL: #14284 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
PR-URL: #14270 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
test/parallel/test-force-repl.js has an unnecessary timer that makes the test flaky under load. Remove it. PR-URL: #14439 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
If JSON.parse() fails, print a message showing the JSON that failed to parse. This is to help with debugging a current test failure on CI. PR-URL: #14508 Ref: #14507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
It doesn't seem to make much sense to have the mentioned typedef
declaration equipped with NODE_EXTERN. In fact, when compiling with GCC,
an attribute specifier like __attribute__((visibility("default"))) in
such a typedef declaration will cause the following warning message:
warning: ‘visibility’ attribute ignored [-Wattributes]
The issue goes unnoticed because NODE_EXTERN is defined as nothing for
GCC builds, but for correctness it's better to not specify it here at
all.
PR-URL: #14466
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #14546 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. PR-URL: #13954 Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
* block scope test cases * clean up global leaks in individual test cases * enable global variable leak checking * remove console.error() statements PR-URL: #14536 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* use common.mustCall() instead of exit handler * use execSync instead of exec so test is reliable under load * move from sequential to parallel PR-URL: #14541 Fixes: #11826 Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com>
This is a very very minor change. PR-URL: #14587 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
PR-URL: #14692 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #14417 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
force-pushed
the
v6.11.3-proposal
branch
2 times, most recently
from
72f0ea5 to
19f39d4
Compare
This LTS release comes with 152 commits. This includes 75 which are test related, 25 which are doc related, 21 which are build / tool related and 3 commits which are updates to dependencies. Notable Changes: * build: - Codesigning is fixed on macOS (Evan Lucas) #14179 * deps: - Snapshots are turned back on!!! (Yang Guo) #14385 * path: - win32 volume-relative paths are working again! (Timothy Gu) #14440 * tools: - v6.x can now build with ICU 59 (Steven R. Loomis) #12078 PR-URL: #14852
MylesBorins
force-pushed
the
v6.11.3-proposal
branch
from
19f39d4 to
dbce2ec
Compare
|
Signing off on CI + CITGM. Running build |
MylesBorins
added a commit
that referenced
this pull request
Sep 5, 2017
This LTS release comes with 152 commits. This includes 75 which are test related, 25 which are doc related, 21 which are build / tool related and 3 commits which are updates to dependencies. Notable Changes: * build: - Codesigning is fixed on macOS (Evan Lucas) #14179 * deps: - Snapshots are turned back on!!! (Yang Guo) #14385 * path: - win32 volume-relative paths are working again! (Timothy Gu) #14440 * tools: - v6.x can now build with ICU 59 (Steven R. Loomis) #12078 PR-URL: #14852
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
This LTS release comes with 152 commits. This includes 75 which are test related, 25 which are doc related, 21 which are build / tool related and 3 commits which are updates to dependencies. Notable Changes: * build: - Codesigning is fixed on macOS (Evan Lucas) nodejs#14179 * deps: - Snapshots are turned back on!!! (Yang Guo) nodejs#14385 * path: - win32 volume-relative paths are working again! (Timothy Gu) nodejs#14440 * tools: - v6.x can now build with ICU 59 (Steven R. Loomis) nodejs#12078 PR-URL: nodejs#14852
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2017-09-05, Version 6.11.3 'Boron' (LTS), @MylesBorins
This LTS release comes with 152 commits. This includes 75 which are test related,
25 which are doc related, 21 which are build / tool related and 3 commits which are updates to dependencies.
Notable Changes
Commits
95be08e3d2] - benchmark: fix typo in inspect-proxy (Vse Mozhet Byt) #14237dbb65203f1] - buffer: remove a wrongly added attribute specifier (Jiajie Hu) #14466977fdce406] - build: codesign tarball binary on macOS (Evan Lucas) #14179a04d4ea8d7] - build: clean up config_fips.gypi (Daniel Bevenius) #13837c7025de6e2] - build: support dtrace on ARM (Bradley T. Hughes) #12193efc0f64c17] - build: reduce one level of spawning in node_gyp (Refael Ackermann) #126531a7e872302] - build,tools: do not force codesign prefix (Evan Lucas) #14179325813ea97] - build,win: fix python detection script (Jason Ginchereau) #14546c2090a0634] - build,windows: restore DISTTYPEDIR (Refael Ackermann) #139692a1a93dcbf] - build,windows: implement PEP514 python detection (Refael Ackermann) #139002bc7c3a8dd] - child_process: fix handleless NODE_HANDLE handling (Santiago Gimeno) #132355900ebe9e4] - crypto: remove root_cert_store from node_crypto.h (Daniel Bevenius) #13194987332abdf] - deps: cherry-pick 18ea996 from c-ares upstream (Anna Henningsen) #138837fed989deb] - deps: cherry-pick f5fad6d from upstream v8 (daniel.bevenius) #1282667ce52c740] - deps: backport rehash strings after deserialization (Yang Guo) #143856518932466] - dns: fixresolvefailed starts without network (XadillaX) #13076438a6427e5] - doc: add gabrielschulhof to collaborators (Gabriel Schulhof) #14692c013c545a4] - doc: update experimental status to reflect use (James M Snell) #12723ad2431ce28] - doc: describe labelling process for backports (Anna Henningsen) #12431013155d0b4] - doc: add XadillaX to collaborators (XadillaX) #14388226ef71a1b] - doc: replace dead link in v8 module (Devin Boyer) #143728b69504e17] - doc: move LTS README link to increase prominence (Gibson Fahnestock) #14259b0286acd52] - doc: update umask for clarity (James Sumners) #1417049d3dee0c2] - doc: correct stream Duplex allowHalfOpen doc (Rich Trott) #141279599faae18] - doc: note 'resize' event conditions on Windows (Dean Coakley) #135768dbf827de3] - doc: fix mistake in http.md (Moogen Tian) #14126a3cd733dea] - doc: fix indentation issues in sample code (Rich Trott) #139503b3d47c483] - doc: add CTC members to Collaborators list (Rich Trott) #13284f1d91ce3d2] - doc: fix example in child_process.md (Ruslan Iusupov) #13716db4fabae27] - doc: note that fs.futimes only works on AIX >7.1 (Gibson Fahnestock) #136597648cca3de] - doc: add @nodejs/documentation to CC table (Vse Mozhet Byt) #13952b03430b4ec] - doc: add gireeshpunathil to collaborators (Gireesh Punathil) #13967c34a7472d2] - doc: fix mistake in path.relative (Tobias Nießen) #139127142c92dd6] - doc: fixed formatting issue in cli docs (Chris Young) #1380887906d25d4] - doc: add missing zlib link to stream API docs (Rob Wu) #138385ba65f2870] - doc: add entry for subprocess.killed property (Rich Trott) #1457873c720dd9e] - doc: changechildtosubprocess(Rich Trott) #145787f6f1c2ddc] - doc, util, console: clarify ambiguous docs (Natanael Log) #14027d6ab8e2f43] - doc,stream: _transform happens one at a time (Matteo Collina) #14321c307f03b2b] - doc,test: fs - reserved characters under win32 (XadillaX) #138751d5ba9c8e9] - docs: add note about fs.rmdir() (Oleksandr Kushchak) #14323f8b60e40a4] - gyp: implement LD/LDXX for ninja and FIPS (Sam Roberts)963ea0e99b] - lib: update indentation of ternaries (Rich Trott) #142470cacd6c89e] - lib: normalize indentation in parentheses (Rich Trott) #141254dabeeecdd] - lib: remove excess indentation (Rich Trott) #14090f20ed49b5e] - lib: use consistent indentation for ternaries (Rich Trott) #1407881edf592ae] - lib: fix typos (Ruben Bridgewater) #1404439f62403c7] - linkedlist: correct grammar in comments (alexbostock) #14546e82a9144ed] - path: remove unnecessary string copies (Tobias Nießen) #14438eefd32264e] - path: fix win32 volume-relative paths (Timothy Gu) #14440fe6735cc19] - src: use existing strings over creating new ones (Anna Henningsen) #145874d3b76d2be] - src: remove GTEST_DONT_DEFINE_ASSERT_EQ in util.h (Daniel Bevenius) #1263851364b746f] - src: move crypto_bio/clienthello to crypto ns (Daniel Bevenius) #1395735f911152a] - src: add missing new line to printed message (Timothy Gu) #13940135e1e3b0b] - src: mergefn_namein NODE_SET_PROTOTYPE_METHOD (XadillaX) #13547403c45fcc9] - src: only call FatalException if not verbose (Daniel Bevenius) #12826547e74bb22] - src: use option parser for expose_internals (Sam Roberts) #12245f9e427945b] - src: supply missing comments for CLI options (Sam Roberts) #122459ca67e0147] - src: make root_cert_vector function scoped (Daniel Bevenius) #127882ce80d97e9] - test: refactor test-domain-abort-on-uncaught (Rich Trott) #145414b9de44022] - test: refactor test-vm-new-script-new-context (Rich Trott) #14536e5375a97e0] - test: add check on an addon that does not register (Ezequiel Garcia) #139541a88c3e5f6] - test: improve error logging for inspector test (Rich Trott) #1450895a95cced3] - test: fix flaky test-force-repl (Rich Trott) #144396fd3dd20c0] - test: replace concatenation with template literal (rockcoder23) #142703ba55d8c47] - test: replace concatenation with template literal (Ching Hsu) #142847f7a0709be] - test: replace concatenation with template literals (Zongmin Lei) #1429811ed4c2823] - test: replace string concatenation with template (ziyun) #14286bbd1c791f5] - test: use path.join for long path concatenation (zzz) #14280c4f21b37a1] - test: replace concatenation with template literals (SkyAo) #14296d7afa17939] - test: fix error handling test-http-full-response (Rich Trott) #142527a8eddf015] - test: use regex error check in test-crypto-random (Zhang Weijie) #142733047cf1b48] - test: check error with regex in test-signal-safety (shaman) #14285bbe328830f] - test: use regex error checks in test-util-format (Superwoods) #14299a696e2ecae] - test: use template literal for string concat (tobewhatwewant) #1428877506e48b0] - test: simplify string concatenation (jiangplus) #14278b9b343c412] - test: use regexp to confir error message (Bang Wu) #1426894ff5918b6] - test: use regluar expression in vm test (akira.xue) #142668b945e7649] - test: use regular expression to match error msg (Flandre) #14265a168361eb9] - test: check complete error message (Fraser Xu) #142641e403902ba] - test: fix flaky test-net-can-reset-timeout (Rich Trott) #14257688e5ed6fd] - test: remove common.noop (Rich Trott) #1282240a61e1399] - test: add get/set effective uid/gid tests (Evan Lucas) #140911633f8b243] - test: simplify test skipping (Vse Mozhet Byt) #14021b7b38bdbaf] - test: adjust indentation for stricter linting (Rich Trott) #1443146e4a026b6] - test: skip test-fs-readdir-ucs2 if no support (Rich Trott) #1402949632287d1] - test: fix flaky http(s)-set-server-timeout tests (Rich Trott) #14380ae7eeff489] - test: fix flaky test-https-set-timeout-server (Rich Trott) #14134c5c65c8ce9] - test: fix require nits in some test-tls-* tests (Vse Mozhet Byt) #14008346f199e28] - test: refactor test-http(s)-set-timeout-server (Alexey Orlenko) #13935ac851c482c] - test: refactor test-http-invalidheaderfield (Rich Trott) #1399649e786628f] - test: replace indexOf with includes and startsWith (Nataly Shrits) #138522eb926b487] - test: remove undef NDEBUG from at-exit addons test (Daniel Bevenius) #139980bcbcca21c] - test: refactor test-fs-watchfile (Rich Trott) #13721bd8574ccee] - test: refactor test-child-process-send-type-error (Rich Trott) #1390474945dd18a] - test: refactor test-cluster-basic (Rich Trott) #13905dc3d29519d] - test: remove unneeded HandleScope usage (Ezequiel Garcia) #13859beca25ab9e] - test: skip fips tests using OpenSSL config file (Daniel Bevenius) #13786d3c85a4806] - test: refactor test-tls-invoked-queued (Rich Trott) #13893676a94e44d] - test: refactor test-tls-env-extra-ca (Rich Trott) #13886fd6bbc098e] - test: make http(s)-set-timeout-server more similar (Julien Klepatch) #138228ba784383c] - test: removerequire('buffer')from 4 test files (XadillaX) #13844cd962e6de3] - test: remove unnecessary require('buffer').Buffer (lena) #13851fff0b83f1b] - test: removerequire('buffer')from 4 test files (Zongmin Lei) #138466d02bf40d0] - test: remove require('buffer') from 4 buffer tests (OriLev) #138550abc82db50] - test: remove require('buffer') on 6 fs test files (sallen450) #138451fb19ac0c5] - test: remove unnecessary Buffer import (Steven Winston) #138605a9d7b3bf5] - test: use string instead of RegExp in split() (Vse Mozhet Byt) #137106731d1b067] - test: remove needless RegExp flags (Vse Mozhet Byt) #13690842b84c4e7] - test: refactor test-http-set-timeout-server (Rich Trott) #13802389f29406a] - test: make test-http(s)-set-timeout-server alike (jklepatch) #136255e9b2030b9] - test: use mustNotCall() in test-fs-watch (Rich Trott) #135959356e9667d] - test: add mustCall() to child-process test (Rich Trott) #13605406b3c0371] - test: use mustNotCall in test-http-eof-on-connect (Rich Trott) #135872f19dcddaa] - test: refactor test-fs-read-* (Rich Trott) #135013bdf7bf9e9] - test: refactor domain tests (Rich Trott) #13480543d2de700] - test: check callback not invoked on lookup error (Rich Trott) #1345691fb0cb6b0] - test: refactor test-dgram-oob-buffer (Rich Trott) #1344308f7cca3b3] - test: add documentation for common.mustNotCall() (Rich Trott) #1335955c96cf8a8] - test: refactor test-net-server-bind (Rich Trott) #13273371b648d1b] - test: use mustCall() in test-readline-interface (Rich Trott) #132593808e3701c] - test: use mustNotCall() in test-stream2-objects (Rich Trott) #13249b793fc6cf6] - test: replaceindexOfwithincludes(Aditya Anand) #13215b7c7112d7b] - test: move stream2 test from pummel to parallel (Rich Trott) #131467a5248d172] - test: simplify assert usage in test-stream2-basic (Rich Trott) #13146e15e2e7a30] - test: check noop function invocations (Rich Trott) #131464a3e089984] - test: confirm callback is invoked in fs test (Rich Trott) #131328b161e0a78] - test: check number of message events (Rich Trott) #13125c2a0a936e1] - test: increase coverage for path.parse (Tobias Nießen) #14438202bfcc1c0] - test: mark test-fs-read-buffer-to-string-fail as flaky (jeyanthinath) #14495a1cef1fc8f] - test: harden test-dgram-bind-shared-ports (Refael Ackermann) #13100f578c9bbb6] - test: add mustCallAtLeast (Refael Ackermann) #12935a7b94500f2] - test: add common.noop, default for common.mustCall() (James M Snell) #12027f3c0b8cd6e] - test,fs: delay unlink in test-regress-test: move ArrayStream to common #4027.js (Jaime Bernardo) #14010e8438c1b22] - timers: do not use user object call/apply (Rich Trott) #1296031f572c3ea] - tools: update to ESLint 4.3.0 (Rich Trott) #144177d851e3b6a] - tools: update package.jsonenginefield (AJ Jordan) #14165c5adb5f008] - tools: update ESLint to 4.2.0 (Rich Trott) #141552af21650d6] - tools: generate template literal for addon tests (Rich Trott) #1409462de339327] - tools: remove legacy indentation linting (Rich Trott) #145158b7c4fc06f] - tools: remove align-multiline-assignment lint rule (Rich Trott) #14079509205fddd] - tools: update to ESLint 4.1.1 (Rich Trott) #139468f664e52d9] - tools: add script to update ESLint (Rich Trott) #13895d34bc78fd4] - tools: update to ESLint 4.1.0 (Rich Trott) #1389501d82d843b] - tools: use no-use-before-define ESLint rule (Vse Mozhet Byt) #1403270901b271c] - tools: remove comment in eslint rule (Daniel Bevenius) #1394574d5cba007] - tools: add missing #include "unicode/putil.h" (Steven R. Loomis) #120787bb200f624] - tools: add rule prefering common.mustNotCall() (James M Snell) #12027d5bf1379b5] - v8: fix RegExp nits in v8_prof_polyfill.js (Vse Mozhet Byt) #137099e2d85e441] - v8: handle proxy objects in MakeMirror(), v2 (Ben Noordhuis) #14343bccd2f59b0] - v8: handle proxy objects in MakeMirror(), v1 (Ben Noordhuis) #14343e79c054f76] - zlib: fix crash when initializing failed (Anna Henningsen) #14666