[backport v6.x] tools: update ESLint to 4.2.0 #14859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
tools
Merged
|
Missing " https" in the third line of metadata in the commit message:
|
|
Hey @Trott. What is the difference between this backport and the version I
landed?
…On Aug 16, 2017 7:28 AM, "Rich Trott" ***@***.***> wrote:
Thanks, @aqrln <https://github.com/aqrln>! Copy/paste error fixed.
And just in case anyone is noticing all the conflicts: This should apply
to 3bd0c7c
<3bd0c7c>,
not to HEAD of the v6.x-staging branch.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#14859 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAecV8p9KwUmFoJXqxoJWYpAd9Ygr1C5ks5sYvyOgaJpZM4O4-Go>
.
|
Not sure. Version you landed was a cherry-pick from master, I imagine. For whatever reason, For this, I rewound to the immediately prior commit on v6.x-staging and updated manually to ESLint 4.2.0 and...oh I see I downgraded the markdown plugin linter from 1.0.0-beta.7 to 1.0.0-beta.4. Maybe that was the problem? Maybe the commit you cherry-picked has to land before the commit that updates the markdown plugin linter to 1.0.0-beta.7 (e5ca046)? |
MylesBorins
force-pushed
the
v6.x-staging
branch
from
22fa484 to
f9419c2
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Aug 16, 2017
ESLint 4.2.0 contains a fix for a bug that is blocking us from moving to the non-legacy stricter indentation linting. Update to 4.2.0 to remove the blocking issue. Backport-PR-URL: #14859 PR-URL: #14155 Ref: eslint/eslint#8882 Ref: eslint/eslint#8885 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
landed 1 |
MylesBorins
pushed a commit
that referenced
this pull request
Sep 5, 2017
ESLint 4.2.0 contains a fix for a bug that is blocking us from moving to the non-legacy stricter indentation linting. Update to 4.2.0 to remove the blocking issue. Backport-PR-URL: #14859 PR-URL: #14155 Ref: eslint/eslint#8882 Ref: eslint/eslint#8885 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MylesBorins Hopefully you can swap this in for 80029b4 and then the rest of the commits that are already on v6.x-staging will unroll over it nicely?
ESLint 4.2.0 contains a fix for a bug that is blocking us from moving to
the non-legacy stricter indentation linting. Update to 4.2.0 to remove
the blocking issue.
PR-URL: #14155
Ref: eslint/eslint#8882
Ref:://github.com/eslint/eslint/pull/8885
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Gibson Fahnestock gibfahn@gmail.com
Reviewed-By: Refael Ackermann refack@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)