n-api: remove n-api module loading flag #14902

gabrielschulhof · 2017-08-17T21:41:13Z

Remove the command line flag that was needed for N-API module loading.

Re: nodejs/vm#9

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Affected core subsystem(s)

n-api

refack

FWIW

refack · 2017-08-17T21:44:08Z

Isn't this semver-minor?

cjihrig

I have a couple questions. If they prove to be nothing, then LGTM.

cjihrig · 2017-08-17T22:16:02Z

test/addons-napi/testcfg.py

@@ -3,4 +3,4 @@
 import testpy

 def GetConfiguration(context, root):
-  return testpy.AddonTestConfiguration(context, root, 'addons-napi', ['--napi-modules'])
+  return testpy.AddonTestConfiguration(context, root, 'addons-napi', [])


The [] can be dropped too I think.

cjihrig · 2017-08-17T22:19:33Z

src/node_api.cc

-  if (!node::load_napi_modules) {
-    // NAPI is disabled, so set the module version to -1 to cause the module
-    // to be unloaded.
-    module_version = -1;


If you remove this line, where is the value set to -1?

cjihrig · 2017-08-17T22:20:15Z

src/node.cc

@@ -2537,27 +2534,20 @@ static void DLOpen(const FunctionCallbackInfo<Value>& args) {
    env->ThrowError("Module did not self-register.");
    return;
  }
-  if (mp->nm_version != NODE_MODULE_VERSION) {
+  if (mp->nm_version == -1) {
+    ProcessEmitWarning(env, "N-API is an experimental feature "


Do any of our tests actually test for the warning?

addaleax · 2017-08-17T22:33:55Z

src/node.cc

@@ -3912,8 +3900,6 @@ static void ParseArgs(int* argc,
      force_repl = true;
    } else if (strcmp(arg, "--no-deprecation") == 0) {
      no_deprecation = true;
-    } else if (strcmp(arg, "--napi-modules") == 0) {
-      load_napi_modules = true;


Maybe leave this in as a no-op for now?

I think that would be a good idea. It will give us time to update docs etc and will avoid breaking people who are already using it.

+1 to leaving it for now.

mhdawson · 2017-08-17T22:54:52Z

FYI @nodejs/ctc, @Fishrock123 to make people who were involved in earlier discussions comment/object in this PR if they still have issues with the approach.

digitalinfinity · 2017-08-18T01:44:41Z

src/node.cc

@@ -2537,27 +2534,20 @@ static void DLOpen(const FunctionCallbackInfo<Value>& args) {
    env->ThrowError("Module did not self-register.");
    return;
  }
-  if (mp->nm_version != NODE_MODULE_VERSION) {
+  if (mp->nm_version == -1) {


Nitpick: Do we want this warning to be printed on every n-api module load or just the first one? Complicates the code slightly but might be a better experience if n-api becomes more common?

typically we emit warnings only on the first use.

mcollina

I would prefer this list to be smashed before this getting in a release.

LGTM

gabrielschulhof · 2017-08-18T10:51:08Z

@mhdawson @digitalinfinity @addaleax @mcollina @cjihrig @refack I have now addressed the review comments.

mhdawson

I'm ok with the changes but marking as "Request changes" so that we avoid landing until we have addressed this comment from @mcollina

I would prefer [this list](https://github.com/nodejs/abi-stable-node/issues/271) to be smashed before this getting in a release.

I think its reasonable that we either address or make the case why we don't need to in advance.

We plan to discuss the one related to CS modules with Bradley in our next regular N-API meeting (Thursday). @aruneshchandra since I think @jasongin is away can you chase down the status on the changes related to async hooks ?

digitalinfinity · 2017-08-30T15:58:29Z

@mhdawson the n-api team chatted with @RReverser and @bmeck last Thursday about ES6 module supprt- the discussion is captured at nodejs/abi-stable-node#256 (comment). TLDR is that n-api will not attempt to provide first class support for any module loader, but we will be making a breaking change (@BoingBoing has already opened #15088)

mhdawson · 2017-08-30T16:53:24Z

Discussed in latest TSC/CTC meeting there did not seem to be objections to removing once we get through the list of breaking changes. Was left that if any TSC/CTC members object they should come and discuss in this PR.

BridgeAR · 2017-09-13T19:10:18Z

@mhdawson it seems like there are no objections anymore besides yours. I think think could land if you are good with it?

mhdawson · 2017-09-13T19:20:53Z

@BridgeAR we are waiting until we have all of the remaining breaking changes in (we are close). We want those to land first as a group and then have this land as a second step.

@gabrielschulhof is in the weekly meeting were we are discussing, so is in the loop as to the next steps.

Once we are ready I'll go ahead and land this one.

mhdawson · 2017-09-14T15:25:03Z

Looks like we are close to landing the remaining breaking changes, CI run:

https://ci.nodejs.org/job/node-test-pull-request/10081/

mhdawson · 2017-09-14T20:33:40Z

Now just waiting on #15108
@sampsongao will add the tests tonight and hopefully we can land Friday Sep 15
And then I'll follow that with this one.

mhdawson

LGTM, just about to land last breaking change so this one can go in as well.

mhdawson · 2017-09-18T22:36:18Z

@gabrielschulhof the tests no longer pass because of the changes to the Init signature. I'm done for today. Can you take a look and I'll try to land tomorrow.

Remove the command line flag that was needed for N-API module loading. Re: nodejs/vm#9

gabrielschulhof · 2017-09-19T20:37:06Z

https://ci.nodejs.org/job/node-test-pull-request/10141/

gabrielschulhof · 2017-09-19T20:50:47Z

Weird linter failure, so I stopped that and started

https://ci.nodejs.org/job/node-test-pull-request/10142/

instead.

gabrielschulhof · 2017-09-19T20:56:56Z

error: The last gc run reported the following. Please correct the root cause
and remove .git/gc.log.
Automatic cleanup will not be performed until the file is removed.

warning: There are too many unreachable loose objects; run 'git prune' to remove them.

gabrielschulhof · 2017-09-19T20:57:23Z

I'll leave it running because make lint passes locally.

Remove the command line flag that was needed for N-API module loading. Re: nodejs/vm#9 PR-URL: nodejs/node#14902 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

@sebdeckers

* **crypto** * Support for multiple ECDH curves. [#15206](#15206) * **dgram** * Added `setMulticastInterface()` API. [#7855](#7855) * **n-api** * The command-line flag is no longer required to use N-API. [#14902](#14902) * **tls** * Docs-only deprecation of `parseCertString()`. [#14245](#14245) * **New Contributors** * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)

@sebdeckers

* **crypto** * Support for multiple ECDH curves. [#15206](#15206) * **dgram** * Added `setMulticastInterface()` API. [#7855](#7855) * Custom lookup functions are now supported. [#14560](#14560) * **n-api** * The command-line flag is no longer required to use N-API. [#14902](#14902) * **tls** * Docs-only deprecation of `parseCertString()`. [#14245](#14245) * **New Contributors** * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)

@sebdeckers

* **crypto** * Support for multiple ECDH curves. [#15206](#15206) * **dgram** * Added `setMulticastInterface()` API. [#7855](#7855) * Custom lookup functions are now supported. [#14560](#14560) * **n-api** * The command-line flag is no longer required to use N-API. [#14902](#14902) * **tls** * Docs-only deprecation of `parseCertString()`. [#14245](#14245) * **New Contributors** * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)

@sebdeckers

* **crypto** * Support for multiple ECDH curves. [#15206](#15206) * **dgram** * Added `setMulticastInterface()` API. [#7855](#7855) * Custom lookup functions are now supported. [#14560](#14560) * **n-api** * The command-line flag is no longer required to use N-API. [#14902](#14902) * **tls** * Docs-only deprecation of `parseCertString()`. [#14245](#14245) * **New Contributors** * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](#15354)

@sebdeckers

* **crypto** * Support for multiple ECDH curves. [#15206](nodejs/node#15206) * **dgram** * Added `setMulticastInterface()` API. [#7855](nodejs/node#7855) * Custom lookup functions are now supported. [#14560](nodejs/node#14560) * **n-api** * The command-line flag is no longer required to use N-API. [#14902](nodejs/node#14902) * **tls** * Docs-only deprecation of `parseCertString()`. [#14245](nodejs/node#14245) * **New Contributors** * Welcome Sebastiaan Deckers (@sebdeckers) as a new Collaborator! [#15354](nodejs/node#15354)

Remove the command line flag that was needed for N-API module loading. Re: nodejs/vm#9 PR-URL: nodejs#14902 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

Remove the command line flag that was needed for N-API module loading. Re: nodejs/vm#9 Backport-PR-URL: #19447 PR-URL: #14902 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <digitalinfinity@gmail.com>

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Aug 17, 2017

refack approved these changes Aug 17, 2017

View reviewed changes

cjihrig approved these changes Aug 17, 2017

View reviewed changes

addaleax approved these changes Aug 17, 2017

View reviewed changes

digitalinfinity approved these changes Aug 18, 2017

View reviewed changes

mcollina approved these changes Aug 18, 2017

View reviewed changes

gabrielschulhof force-pushed the remove-flag branch from 513fe34 to e6ad4b5 Compare August 18, 2017 10:49

gabrielschulhof force-pushed the remove-flag branch from e6ad4b5 to 9b78363 Compare August 18, 2017 10:53

mhdawson requested changes Aug 18, 2017

View reviewed changes

mhdawson mentioned this pull request Aug 30, 2017

Node.js Foundation Core Technical Committee (CTC) Meeting 2017-08-30 nodejs/CTC#171

Closed

mhdawson mentioned this pull request Aug 30, 2017

drop --napi-modules earlier than dropping the "experimental" status nodejs/vm#9

Closed

jasnell approved these changes Aug 30, 2017

View reviewed changes

mhdawson approved these changes Sep 18, 2017

View reviewed changes

n-api: remove n-api module loading flag

ca5d54f

Remove the command line flag that was needed for N-API module loading. Re: nodejs/vm#9

gabrielschulhof force-pushed the remove-flag branch from 9b78363 to ca5d54f Compare September 19, 2017 20:32

gabrielschulhof deleted the remove-flag branch September 25, 2017 09:20

MylesBorins added the dont-land-on-v6.x label Oct 17, 2017

richardlau mentioned this pull request Apr 16, 2018

documentation of --napi-modules #20082

Closed

MylesBorins mentioned this pull request Apr 16, 2018

v6.14.2 proposal #19996

Merged

bnoordhuis mentioned this pull request Apr 18, 2018

src: kickstart addon by calling its constructor #20114

Closed

4 tasks

richardlau mentioned this pull request Apr 25, 2018

n-api: update cli documentation #20301

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

n-api: remove n-api module loading flag #14902

n-api: remove n-api module loading flag #14902

gabrielschulhof commented Aug 17, 2017

refack left a comment

refack commented Aug 17, 2017

cjihrig left a comment

cjihrig Aug 17, 2017

cjihrig Aug 17, 2017

cjihrig Aug 17, 2017

addaleax Aug 17, 2017

mhdawson Aug 17, 2017

jasnell Aug 18, 2017

mhdawson commented Aug 17, 2017

digitalinfinity Aug 18, 2017

jasnell Aug 18, 2017

mcollina left a comment

gabrielschulhof commented Aug 18, 2017

mhdawson left a comment •

edited

Loading

digitalinfinity commented Aug 30, 2017

mhdawson commented Aug 30, 2017

BridgeAR commented Sep 13, 2017

mhdawson commented Sep 13, 2017

mhdawson commented Sep 14, 2017

mhdawson commented Sep 14, 2017 •

edited

Loading

mhdawson left a comment

mhdawson commented Sep 18, 2017

gabrielschulhof commented Sep 19, 2017

gabrielschulhof commented Sep 19, 2017

gabrielschulhof commented Sep 19, 2017

gabrielschulhof commented Sep 19, 2017

n-api: remove n-api module loading flag #14902

n-api: remove n-api module loading flag #14902

Conversation

gabrielschulhof commented Aug 17, 2017

Checklist

Affected core subsystem(s)

refack left a comment

Choose a reason for hiding this comment

refack commented Aug 17, 2017

cjihrig left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mhdawson commented Aug 17, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

gabrielschulhof commented Aug 18, 2017

mhdawson left a comment • edited Loading

Choose a reason for hiding this comment

digitalinfinity commented Aug 30, 2017

mhdawson commented Aug 30, 2017

BridgeAR commented Sep 13, 2017

mhdawson commented Sep 13, 2017

mhdawson commented Sep 14, 2017

mhdawson commented Sep 14, 2017 • edited Loading

mhdawson left a comment

Choose a reason for hiding this comment

mhdawson commented Sep 18, 2017

gabrielschulhof commented Sep 19, 2017

gabrielschulhof commented Sep 19, 2017

gabrielschulhof commented Sep 19, 2017

gabrielschulhof commented Sep 19, 2017

mhdawson left a comment •

edited

Loading

mhdawson commented Sep 14, 2017 •

edited

Loading