Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update V8 to 6.1.534.42 #15521

Merged
merged 1 commit into from
Sep 28, 2017
Merged

deps: update V8 to 6.1.534.42 #15521

merged 1 commit into from
Sep 28, 2017

Conversation

targos
Copy link
Member

@targos targos commented Sep 21, 2017 •
edited
Loading

Refs: v8/v8@6.1.534.38...6.1.534.42

/cc @nodejs/v8

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

V8

@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Sep 21, 2017
bnoordhuis
bnoordhuis approved these changes Sep 21, 2017
View reviewed changes
deps/v8/src/flag-definitions.h
@@ -465,7 +465,7 @@ DEFINE_BOOL(turbo_loop_peeling, true, "Turbofan loop peeling")
DEFINE_BOOL(turbo_loop_variable, true, "Turbofan loop variable optimization")
DEFINE_BOOL(turbo_cf_optimization, true, "optimize control flow in TurboFan")
DEFINE_BOOL(turbo_frame_elision, true, "elide frames in TurboFan")
DEFINE_BOOL(turbo_escape, true, "enable escape analysis")
DEFINE_BOOL(turbo_escape, false, "enable escape analysis")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is https://bugs.chromium.org/p/chromium/issues/detail?id=765433, currently under embargo.

Doesn't affect Node.js in that it depends on executing untrusted code (which no one should do.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we should revert this change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not at all, I only commented to add some context.

@targos
Copy link
Member Author

targos commented Sep 21, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10178/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/920/

@targos
Copy link
Member Author

targos commented Sep 21, 2017

The new V8 tests don't pass:

const maxLength = %StringMaxLength();
                                   ^
SyntaxError: StringMaxLength is not defined

That's because the StringMaxLength runtime function does not exist in V8 6.1
It's apparently a known issue: https://chromium-review.googlesource.com/c/v8/v8/+/675903#message-a299ddf23c6b250649899d7fa0921522e9551feb

@targos
Copy link
Member Author

targos commented Sep 21, 2017

I pushed a fix. New CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/921/

@targos
Copy link
Member Author

targos commented Sep 21, 2017

It's green. I'm trying to upstream the fix here: https://chromium-review.googlesource.com/c/v8/v8/+/677300

MylesBorins
MylesBorins approved these changes Sep 21, 2017
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp LGTM

@targos targos changed the title deps: update V8 to 6.1.534.41 deps: update V8 to 6.1.534.42 Sep 22, 2017
@addaleax
Copy link
Member

@jasnell Can we include this in #15509?

BridgeAR
BridgeAR approved these changes Sep 24, 2017
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@targos
Copy link
Member Author

targos commented Sep 25, 2017

CI before landing: https://ci.nodejs.org/job/node-test-pull-request/10246/

@MylesBorins
Copy link
Contributor

one more try

ci: https://ci.nodejs.org/job/node-test-pull-request/10305/
v8: https://ci.nodejs.org/job/node-test-commit-v8-linux/931/

@targos
deps: update V8 to 6.1.534.42
2b196fb 
Refs: v8/v8@6.1.534.38...6.1.534.42

PR-URL: nodejs#15521
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@targos targos merged commit 2b196fb into nodejs:master Sep 28, 2017
@targos
Copy link
Member Author

targos commented Sep 28, 2017

Failures are unrelated to this PR.
Landed in 2b196fb

@targos targos deleted the update-v8-41 branch September 28, 2017 11:47
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@targos @MylesBorins
deps: update V8 to 6.1.534.42
37d1779 
Refs: v8/v8@6.1.534.38...6.1.534.42

PR-URL: #15521
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@targos @MylesBorins
deps: update V8 to 6.1.534.42
a093598 
Refs: v8/v8@6.1.534.38...6.1.534.42

PR-URL: #15521
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@targos @addaleax
deps: update V8 to 6.1.534.42
fa49f66 
Refs: v8/v8@6.1.534.38...6.1.534.42

PR-URL: nodejs/node#15521
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@targos @MylesBorins
deps: update V8 to 6.1.534.42
4a7ac6f 
Refs: v8/v8@6.1.534.38...6.1.534.42

PR-URL: #15521
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@targos @MylesBorins
deps: update V8 to 6.1.534.42
97c0880 
Refs: v8/v8@6.1.534.38...6.1.534.42

PR-URL: #15521
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@ofrobots ofrobots ofrobots approved these changes

@jasnell jasnell jasnell approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

@bmeurer bmeurer bmeurer approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@targos @addaleax @MylesBorins @ofrobots @bnoordhuis @jasnell @bmeurer @cjihrig @BridgeAR @nodejs-github-bot