Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v8.7.0 proposal #15762

Merged
merged 209 commits into from
Oct 11, 2017
Merged

v8.7.0 proposal #15762

merged 209 commits into from
Oct 11, 2017

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Oct 3, 2017

2017-10-11, Version 8.7.0 (Current), @MylesBorins

Notable Changes

  • deps:
    • update npm to 5.4.2
      #15600
    • upgrade libuv to 1.15.0
      #15745
    • update V8 to 6.1.534.42
      15393
  • dgram:
    • support for setting dgram socket buffer size
      #13623
  • fs:
    • add support O_DSYNC file open constant
      #15451
  • util:
    • deprecate obj.inspect for custom inspection
      #15631
  • tools, build:
    • there is a fancy new macOS installer
      #15179
  • Added new collaborators

Commits

  • [16bdbb9e76] - async_hooks: fix reference in code comment (Brian White) #15748
  • [1bc0c1fb5f] - async_hooks: consistent internal naming (Andreas Madsen) #15569
  • [9da8346c96] - async_wrap: allow user to pass execution_async_id (Trevor Norris) #14208
  • [09b3faef40] - async_wrap: add constructor for PromiseWrap (Trevor Norris) #14208
  • [67cef9b182] - build: allow build with system python 3 (Emily Marigold Klassen) #16058
  • [3d2481e6cb] - build: call setlocal in vcbuild.bat (Daniel Bevenius) #15754
  • [ed8c89a07d] - build: fix shared installing target (Yorkie Liu) #15148
  • [7dd0ca40e2] - build: run es-module tests in CI (Benjamin Coe) #15276
  • [81515c7b62] - build: add test-with-async-hooks (Trevor Norris) #14208
  • [1ed0c7706f] - crypto: better crypto error messages (Greg Alexander) #15518
  • [be4e809af2] - crypto: use X509V3_EXT_d2i (David Benjamin) #15348
  • [93d5ead37a] - crypto: use SSL_SESSION_get_id (David Benjamin) #15348
  • [9eeaab4ba5] - crypto: only try to set FIPS mode if different (Gibson Fahnestock) #12210
  • [77bdfc96ae] - deps: upgrade libuv to 1.15.0 (cjihrig) #15745
  • [c17ff62376] - deps: cherry-pick f4a2b7f3 from V8 upstream. (Erin Spiceland) #16053
  • [1c0ae10c26] - deps: V8: cherry-pick 163d360 from upstream (Ali Ijaz Sheikh) #15664
  • [3f2ea53043] - deps: update npm to 5.4.2 (Michaël Zasso)
  • [6a019183c6] - deps: cherry-pick 0353a1e from upstream V8 (Michaël Zasso) #15599
  • [97c0880052] - deps: update V8 to 6.1.534.42 (Michaël Zasso) #15521
  • [b4ad15be5f] - deps: cherry-pick 9b21865822243 from V8 upstream (Anna Henningsen) #15391
  • [e1828eb50d] - deps: cherry-pick b6158eb6befae from V8 upstream (Anna Henningsen) #15391
  • [aa1a3ea998] - (SEMVER-MINOR) deps: revert ABI breaking changes in V8 6.1 (Anna Henningsen) #15393
  • [847174759d] - deps: patch V8 to 6.1.534.38 (Myles Borins) #15431
  • [c0b5b09381] - (SEMVER-MINOR) deps: add postmortem metadata for V8 TurboFan (Michaël Zasso) #14730
  • [9934dfeb5e] - deps: cherry-pick 1aead19 from upstream V8 (Ben Noordhuis) #15184
  • [273822f756] - deps: cherry-pick e020aae394 from V8 upstream (Ben Noordhuis) #14913
  • [d85283b76b] - deps: backport f9c4b7a from upstream V8 (Matt Loring) #14001
  • [19a5021ee3] - deps: backport bca8409 from upstream V8 (Matt Loring) #14001
  • [2601a515f9] - deps: backport 6e9e2e5 from upstream V8 (Matt Loring) #14001
  • [ede9d2ed8e] - (SEMVER-MINOR) deps: cherry-pick f19b889 from upstream V8 (Michaël Zasso) #14730
  • [63ebad5a04] - (SEMVER-MINOR) deps: fix addons compilation with VS2013 (Bartosz Sosnowski) #13263
  • [21004dda00] - deps: limit regress/regress-crbug-514081 v8 test (Michael Dawson) #6678
  • [d67fb8188f] - (SEMVER-MINOR) deps: update V8 to 6.1.534.36 (Michaël Zasso) #15393
  • [827f843dfa] - dgram: refactor SO_RCVBUF and SO_SNDBUF methods (cjihrig) #15483
  • [e3658143e5] - (SEMVER-MINOR) dgram: support for setting socket buffer size (Damien O'Reilly) #13623
  • [bae46dc806] - doc: add kfarnung to collaborators (Kyle Farnung) #16108
  • [d1266a3c57] - doc: mention collaboration summit in onboarding.md (Joyee Cheung) #16079
  • [140c98b327] - doc: document the benchmark CI (Joyee Cheung) #16086
  • [66a2c710f2] - doc: fix macosx-firewall suggestion BUILDING (suraiyah) #15829
  • [44719ed74d] - doc: add clearer setup description (Emily Platzer) #15962
  • [9f6d535b87] - doc: update style guide for markdown extension (Rich Trott) #15786
  • [acd4924448] - doc: fix http2 API docs typos (Daniela Borges Matos de Carvalho) #15778
  • [74755415cc] - doc: fix: correctly use public key instead of private key (Pavel Pomerantsev) #16038
  • [0ae84c2434] - doc: fix incorrect vm.createContext usage (tshemsedinov) #16059
  • [344d6132ee] - doc: fix YAML syntax in fs.md (Luigi Pinca) #15769
  • [df1d988270] - doc: explain common.restore* functions (Rich Trott) #15720
  • [dcad2df78b] - doc: fix typo in tls.md (kohta ito) #15738
  • [979e38b13c] - doc: add 'git clean -xfd' to backport guide (Lance Ball) #15715
  • [978f78ef01] - doc: alphabetize TSC Emeriti in README.md (Rich Trott) #15722
  • [54a43a6d38] - doc: change encoding to decoding (Sakthipriyan Vairamani (thefourtheye)) #15706
  • [cf579eae25] - doc: fix dead link in doc/releases.md (Luigi Pinca) #15733
  • [fcea265421] - doc: fix v8.6 changelog entry (Ruben Bridgewater) #15716
  • [5630c8cd5d] - doc: add missing TOC entry in CONTRIBUTING.md (Vse Mozhet Byt) #15729
  • [db0ba97bec] - doc: update fs.utimes{,Sync} changelog (Luigi Pinca) #15680
  • [cc902832e2] - doc: edit COLLABORATORS_GUIDE.md for readability (Rich Trott) #15629
  • [f8e93e888e] - doc: fix links in some intra-repository docs (Vse Mozhet Byt) #15675
  • [9c247c56ab] - doc: standardize function param/object prop style (Gibson Fahnestock) #13769
  • [e5b5a03e00] - doc: do not begin yaml value with backtick (Jon Moss) #15447
  • [f8805c4465] - doc: fix link in the test/README.md (Rimas Misevičius) #15642
  • [1141e930a3] - doc: update libuv license (Timothy Gu) #15649
  • [db70874c8f] - doc: add bmeurer to collaborators (Benedikt Meurer) #15677
  • [ec56cbe572] - doc: improve fs.utimes (Refael Ackermann) #14154
  • [6565ddabd0] - doc: add callback function signatures in fs.md (Matej Krajčovič) #13424
  • [22b2d1a786] - doc: fix mistake in http2stream.respondWithFile. (Antoine AMARA) #15501
  • [d1d2ca5bef] - doc: retire bnoordhuis from the TSC (Ben Noordhuis) #15626
  • [e0a76347d4] - doc: update table of contents for common/README.md (Rich Trott) #15595
  • [6003afcc71] - doc,test: minor improvements to O_DSYNC (Tobias Nießen) #15547
  • [a814a551f3] - (SEMVER-MINOR) fs: add O_DSYNC (Jussi Räsänen) #15451
  • [9c1e48dca5] - http: client keep-alive for UNIX domain sockets (Bryan English) #13214
  • [10622c6331] - http2: near full http1 compatibility, add tests (Anatoli Papirovski) #15702
  • [86dfcc609c] - http2: making sending to the socket more efficient (James M Snell) #15693
  • [68cd233a7b] - http2: eliminate dead code (James M Snell) #15693
  • [078ee27f13] - http2: refactor method arguments to avoid bools (James M Snell) #15693
  • [86ee05d5ca] - http2: simplify TypeName (James M Snell) #15693
  • [df271f4f00] - http2: setting shuttingDown=true after validation (Trivikram Kamat) #15676
  • [a4a5bee933] - http2: adjust error emit in core, add tests (Anatoli Papirovski) #15586
  • [5f469a26f3] - n-api: add check for large strings (Michael Dawson) #15611
  • [de52eb8680] - perf_hooks: remove docs for unimplemented API (Sam Roberts) #15641
  • [e4c461ba7d] - src: replace manual memory mgmt with std::string (Ben Noordhuis) #15782
  • [6642f54184] - src: fix ^ in stack trace with vm's columnOffset (Timothy Gu) #15771
  • [824b8dfe9e] - src: remove unused node_dtrace.h from node_win32 (Daniel Bevenius) #15768
  • [0004214ea7] - src: trace_event macro line continuation cleanup (Daniel Bevenius) #15750
  • [15063844cb] - src: fix windows-only build breakage (Ben Noordhuis) #15724
  • [965efd7b47] - src: remove unused includes in src/tracing (Daniel Bevenius) #15682
  • [64d0c7422d] - src: use UV_EINVAL instead of EINVAL in udp_wrap (Daniel Bevenius) #15444
  • [6551bb3ace] - src: fix compiler warning in udp_wrap.cc (Daniel Bevenius) #15402
  • [7e1003aad3] - src: remove unused using in node_trace_writer.h (Daniel Bevenius) #15646
  • [25fd85df36] - src: add help for NODE_PENDING_DEPRECATION env (Thomas Corbière) #15609
  • [ca02576fb4] - src: fix typo in probe description (Evan Lucas) #15397
  • [69f8738a59] - src: remove unused variable in node_url.cc (cjihrig) #15592
  • [9fcf5d7f25] - src: remove unused computation (cjihrig) #15593
  • [44ea5254f3] - src: clear async id stack if bootstrap throws (Trevor Norris) #15553
  • [67205391b3] - src: move node_trace_writer/buffer.h to agent.cc (Daniel Bevenius) #15598
  • [fd1a8924fd] - src: constify PerformanceEntry data members (Ben Noordhuis) #15458
  • [e72761a27f] - src: return references from getters, not copies (Ben Noordhuis) #15458
  • [aded597c10] - src: handle uv_async_init() failure (Ben Noordhuis) #15458
  • [d202c05f7e] - src: remove unused static variable (Ben Noordhuis) #15458
  • [902feeaad8] - src: use InstantiateModule instead of deprecated (Daniel Bevenius) #15423
  • [e8da556eca] - src: keep track of env properly in node_perf.cc (Anna Henningsen) #15391
  • [2e8652e164] - (SEMVER-MINOR) src: fix SmartOS compilation (Michaël Zasso) #14730
  • [a43f681c20] - src,etw: fix event 9 on 64 bit Windows (João Reis) #15563
  • [ae91ffe53c] - stream: fix disparity between buffer and the count (jlvivero) #15661
  • [3d6390b32b] - stream: fix todo (Ruben Bridgewater) #15667
  • [6f42b680e3] - test: replace common.fixturesDir w/ fixtures.path (Druotic) #15819
  • [b1e6373dcc] - test: replaces fixturesDir with fixtures (Alireza Alidousti) #15838
  • [50cae5c44f] - test: remove assert message (Joe Henry)
  • [e48c8b3b6c] - test: replace fixtureDir with fixtures.path (matthewreed26) #15943
  • [572492a088] - test: clarify assert messages in crypto tests (cpandrews8) #16019
  • [d962ee35de] - test: use common.fixtures module for file path (Adil L) #16017
  • [8f367bb1a6] - test: fix race condition in addon test (Kinnan Kwok) #16037
  • [5d63c1033d] - test: create benchmark test for misc and module (Charles T Wall III) #16044
  • [e9f6a624db] - test: include expected result in error messages (Chowdhurian) #16039
  • [f8496553df] - test: use fixtures module (Maurice Hayward) #16034
  • [e4f0483fb9] - test: replace fixturesDir with fixtures module (tabulatedreams) #16036
  • [387b0b8b10] - test: replace concat with template literals (gitHubTracey) #15885
  • [6e25b081b6] - test: clarify assertion failure (ryshep111) #15889
  • [6a44442b5f] - test: use fixtures.readKey (Robin Lungwitz) #15892
  • [f7ab12685e] - test: replace fixturesDir with fixtures module (Ivan Etchart) #15893
  • [36a0d3f0b1] - test: cleanup test-buffer-sharedarraybuffer (Rafal Leszczynski) #15896
  • [bbbf58e951] - test: change fixturesDir to fixtures.path (Savio Lucena) #15902
  • [dba620b178] - test: changed fixtures require (creisle) #15899
  • [ccecaca056] - test: replaced fixturesDir with fixtures module (Alex McKenzie) #15908
  • [547c284335] - test: replace string concatenation with templates (Colin Leong) #15903
  • [a625d82c78] - test: updated error message (Emily Platzer) #15906
  • [3b682aa857] - test: assert.strictEqual using template literals (jmcgui05) #15944
  • [329d22fb32] - test: use common.fixtures in tls test (Ben Michel) #15965
  • [9f9bd38aa0] - test: replace error msg w/ template literal (Sushil Tailor) #15910
  • [181d4bf5b3] - test: add NODE_UNIQUE_ID value to err message (Daniele Lisi) #15914
  • [2d25a3b5f8] - test: replace string concatenation with template (Rob Paton) #15915
  • [802f99ba27] - test: change concatenation to template literal (nodexpertsdev) #15916
  • [c5c51ebae4] - test: improve asset msg in test (Gene Wu) #15918
  • [f201edc4be] - test: replace fixturesDir with fixtures module (penDerGraft) #15919
  • [906f2b14ca] - test: remove message from asserts (Justin Lee) #15920
  • [a14b447bbb] - test: improve an error message (Pavel Pomerantsev) #15921
  • [27e0532eab] - test: added string_decoder.js a parallel test (Uttam Pawar) #15923
  • [2ea339a346] - test: use fixtures module instead of common (Joe Grace) #15925
  • [5bfc4f5e5a] - test: replace fixtureDir with fixtures module (Charlie Duong) #15823
  • [7d8a808959] - test: replaced fixturesDir with fixtures module (Alex McKenzie) #15881
  • [d3272c487a] - test: use common.fixtures module (Christopher Choi) #15891
  • [e7c55bf77d] - test: replaced literals in errors with templates (Paul Milham) #15911
  • [205927fe6b] - test: display better error message for assertion (Russell Dempsey) #15883
  • [768060d5e7] - test: changed buffer-zero output (heeeunkimmm) #15926
  • [0286da0992] - test: replaced fixturesDir with fixtures module (Alex McKenzie) #15927
  • [84dd5783c6] - test: remove literal error messages (Faisal Yaqoob) #15928
  • [633772a90c] - test: refactor test to use the fixtures module (Daniel Kostro) #15934
  • [dd23140015] - test: replace fixturesDir with fixtures module (Greg Matthews) #15932
  • [5b29e5a1f3] - test: modify test messages to template literals (Alice Tsui) #15931
  • [7df8e0b0db] - test: replace common.fixturesDir with fixture (BradLarson) #15940
  • [26536e46ed] - test: changes to use template literal (joanne-jjb) #15937
  • [e12dc40c2f] - test: replace fixturesDir with fixtures (Mujtaba Al-Tameemi) #15949
  • [30631528e4] - test: remove common.fixturesDir (Luis Del Águila) #15950
  • [9059b09a34] - test: remove template literal (Emily Ford) #15953
  • [ba9aa46b6d] - test: removed string from assert message arg (dpaulino) #15954
  • [3fd4f62f35] - test: replace literal with template string (Brant Barger) #15957
  • [a224760639] - test: upgrade from fixturesDir to fixtures.path (jacjam) #15960
  • [b564fe2231] - test: use defaultHistoryPath instead of path.join (Chris Budy) #15969
  • [ece6cd1f9e] - test: replace fixturesDir with fixtures module (BinarySo1o) #15961
  • [d1bb608b45] - test: replaced fixturesDir with common.fixtures (jopann) #15971
  • [adceca44b2] - test: improve assert messages (Eric Pemberton) #15972
  • [ab046beeeb] - test: replacing assert message with template (Barry Tam) #15974
  • [75ab6c00a9] - test: use common.fixtures module in test-preload (Laura Cabrera) #15975
  • [530b62fc0d] - test: more informative test failure messages (Alec Ferguson) #15977
  • [4a9e3312fd] - test: alter assert.strictEqual to default message (Luke Greenleaf) #15978
  • [e9d31bc6e4] - test: replaced common.fixturesDir with readKey (Sean Cox) #15933
  • [054f8f6683] - test: replace fixturesDir in tls-env-bad-extra-ca (Annie Weng) #15813
  • [d410f74e23] - test: use common.fixtures in checkServerIdentity (Emily Marigold Klassen) #15951
  • [145d1db923] - test: replaced common.fixturesDir with readKey (rhalldearn) #15952
  • [9592a486e0] - test: use fixtures.path for cmd string building (John Miller) #15982
  • [4594315eae] - test: replace fixturesDir with fixtures.readKey (Thomas Schorn) #15948
  • [73231d95af] - test: replace common.fixturesDir with readKey (ashleyraymaceli) #15946
  • [73a41cf653] - test: replace common.fixturesDir with fixtures. (Sam Skjonsberg) #15802
  • [de198a9dc0] - test: update test to use fixtures module (gbugaisky) #15955
  • [7ca02b0f0c] - test: replace fixturesDir with common.fixtures (rachelnicole) #16051
  • [1d7e1c0f18] - test: remove messages in assert.strictEqual (Saeed H) #16014
  • [8ea96488bc] - test: update fixturesDir to fixtures.readKey (bitandbang) #16016
  • [b766d27197] - test: replace fixturesDir with common.fixtures (Paul Berry) #15973
  • [c47ebe20dd] - test: replace fixturesDir with common.fixtures (Pooya Paridel) #15837
  • [516fda6c64] - test: update 'fixturesDir' refs in a test file (James M. Greene) #15824
  • [e1a1d2e13d] - test: replace common.fixturesDir in test-exception (Chowdhurian) #15964
  • [47169216d8] - test: use fixtures.readKey in https-agent test (Greg Byram) #15913
  • [f39c7926cf] - test: http2 client destroy tests in one file (Trivikram Kamat) #15749
  • [21a8a820a3] - test: add common.fixtures to https-req-split (Bruce Fletcher) #15801
  • [bd49ada52a] - test: http2 stored settings returned when present (Trivikram Kamat) #15751
  • [1e79a06ac6] - test: fix flaky async-hooks/test-tlswrap (Rich Trott) #15744
  • [22ea3a8cd2] - test: remove common.PORT from test-tlswrap (Rich Trott) #15742
  • [3f1210992c] - test: refactor test-internal-errors (Rich Trott) #15721
  • [995948a1f9] - test: skip test if host is too slow (Rich Trott) #15688
  • [af304b21c7] - test: mark test-bindings and test-debug-end flaky (João Reis) #15747
  • [1582260067] - test: increase test coverage for os.js (kuroljov) #14098
  • [88f69d3ec3] - test: check that this != new.target in addon (Ben Noordhuis) #15681
  • [7842f63069] - test: Http2Stream destroy server before shutdown (Trivikram Kamat) #15597
  • [41539381fe] - test: http2Stream redundant shutdown and single cb (Trivikram Kamat) #15612
  • [803d5bbf50] - test: update es-module.status prefix (Jack Horton) #15690
  • [bd7b216936] - test: fix test-https-writable-true-after-close (Rich Trott) #15705
  • [0aea258f0e] - test: fix http-writable-true-after-close flakyness (Matteo Collina) #15520
  • [bbdd93f34f] - test: skip test when checking async_hooks (Trevor Norris) #14208
  • [98fc665940] - test: print resource stack on error (Trevor Norris) #14208
  • [ab7448e0d5] - tools: replace concatenation with string templates (Ethan Arrowood) #15858
  • [0e707f3f9e] - tools: replace concat with template literals (Minya Liang) #16046
  • [ca5f4f0ed3] - tools: use more template literals (Govee91) #15942
  • [94c6296d83] - tools: use template literals (Sarah Meyer) #15956
  • [eebb2d775a] - (SEMVER-MINOR) tools, build: refactor macOS installer (JP Wesselink) #15179
  • [f68f572d7f] - tty: require readline at top of file (Bryan English) #15647
  • [d181147b2c] - url: const-ify APIs, and pass URL by ref (Sam Roberts) #15615
  • [1cc4245bfb] - url: fix remaining calculation (Rimas Misevičius) #15637
  • [34b4180d7d] - url: change variable name to be more descriptive (Yang-Kichang) #15551
  • [58c68c2fcb] - util: use faster -0 check (Brian White) #15726
  • [d2e1545406] - (SEMVER-MINOR) util: deprecate obj.inspect for custom inspection (Rich Trott) #15631

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. v8.x labels Oct 3, 2017
targos and others added 25 commits October 3, 2017 14:03
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
Backport-PR-URL: #15393
PR-URL: #6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
VS2013 does not support defaulting move constructor and assignment
operator. This adds explicit definitions of those methods for two
classes.
This fix is required because we still support building addons with
VS2013 and the incompatibility is in v8.h.

Fixes: nodejs/node-v8#4

Backport-PR-URL: #15393
PR-URL: #13263
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Original commit message:

    [inspector] support for cases when embedder doesn't call contextDestroyed

    Node.js doesn't have good place to call contextDestroyed.
    We need to cleanup everything on our side to allow clients to not call
    contextDestroyed method.

    R=dgozman@chromium.org,eostroukhov@chromium.com

    Bug: none
    Change-Id: Ibe3f01fd18afbfa579e5db66ab6f174d5fad7c82
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/575519
    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Original-Commit-Position: refs/heads/master@{#46849}
    Reviewed-on: https://chromium-review.googlesource.com/596549
    Cr-Commit-Position: refs/heads/master@{#47060}

Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Original commit message:

  [heap] Move SweeperTask to CancelableTask
  This mitigates the problem of blocking on the main thread when the
  platform is unable to execute background tasks in a timely manner.

  Bug: v8:6655
  Change-Id: Icdaae744ee73146b86b9a28c8035138746721971
  Reviewed-on: https://chromium-review.googlesource.com/595467
  Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
  Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#47036}

Backport-PR-URL: #15393
PR-URL: #14001
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Original commit message:

  Make CancelableTask ids unique
  They were only limited to 32 bit when using the internal Hashmap. Since
  this has changed alreay some time ago, we can switch to 64 bit ids and
  check that we never overflow.

  Bug:
  Change-Id: Ia6c6d02d6b5e555c6941185a79427dc4aa2a1d62
  Reviewed-on: https://chromium-review.googlesource.com/598229
  Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
  Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#47085}

Backport-PR-URL: #15393
PR-URL: #14001
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Original commit message:

  [heap] Move UnmapFreeMemoryTask to CancelableTask
  This mitigates the problem of blocking on the main thread when the
  platform is unable to execute background tasks in a timely manner.

  Bug: v8:6671
  Change-Id: I741d4b7594e8d62721dad32cbfb19551ffacd0c3
  Reviewed-on: https://chromium-review.googlesource.com/599528
  Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
  Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
  Cr-Commit-Position: refs/heads/master@{#47126}

Backport-PR-URL: #15393
PR-URL: #14001
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Original commit message:

    Work around glibc thread-local storage bug

    glibc before 2.17 has a bug that makes it impossible to execute
    binaries that have single-byte thread-local variables:

        % node --version
        node: error while loading shared libraries: cannot allocate
        memory in static TLS block

    Work around that by making the one instance in the V8 code base
    an int.

    See: https://sourceware.org/bugzilla/show_bug.cgi?id=14898
    See: nodesource/distributions#513
    See: nodejs/build#809
    Change-Id: Iefd8009100cd93e26cf8dc5dc03f2d622b423385
    Reviewed-on: https://chromium-review.googlesource.com/612351
    Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl>
    Reviewed-by: Eric Holk <eholk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47400}

Backport-PR-URL: #15393
PR-URL: #14913
Ref: nodejs/build#809
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Original commit message:

    Add postmortem metadata for thin strings.

    See: nodejs/llnode#117
    Change-Id: Icc2830c8e9096610df33ffdc2f89e74cb1b35662
    Reviewed-on: https://chromium-review.googlesource.com/618986
    Reviewed-by: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Ben Noordhuis <info@bnoordhuis.nl>
    Cr-Commit-Position: refs/heads/master@{#47778}

Backport-PR-URL: #15393
PR-URL: #15184
Ref: nodejs/llnode#117
Ref: nodejs/llnode#121
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Refs: nodejs/llnode#130
Refs: https://chromium-review.googlesource.com/c/v8/v8/+/650746
Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Refs: nodejs/node-v8#8
Backport-PR-URL: #15393
PR-URL: #14730
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Created using the update-v8 npm module and the command
`update-v8 minor`.

Refs: v8/v8@6.1.534.36...6.1.534.38

Backport-PR-URL: #15393
PR-URL: #15431
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Below is the list of changes:

    deps: revert 70de12b73c150 from upstream V8

    Original commit message:

        Remove deprecated ForceSet

        Also move the soon-to-be-deprecated version to deprecated

        BUG=none
        R=ulan@chromium.org

        Change-Id: I2252404f63e25ac35c7798daf66b36144bef6a7e
        Reviewed-on: https://chromium-review.googlesource.com/518162
        Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
        Commit-Queue: Jochen Eisinger <jochen@chromium.org>
        Cr-Commit-Position: refs/heads/master@{#45554}

    [squash] use renamed internal utilities

    v8: reorder V8_INTRINSICS_LIST for ABI compat

    Make `kErrorPrototype` added at the end of the `Intrinsic` for
    ABI compatibility.

    deps: revert 0089c786ed882 from V8 upstream

    Original commit message:

        Merged: Squashed multiple commits.

        Merged: [heap] Add API to set heap semi-space limits in KB.
        Revision: bb29f9a4d6fb5e32

        Merged: [heap] Partially reland "Allow a minimum semi-space size of 512K."
        Revision: 7486dc3331

        Merged: [heap] Set initial semi-space size to 512K.
        Revision: a5230d81d1f73c

        BUG=chromium:716032,chromium:735649
        LOG=N
        NOTRY=true
        NOPRESUBMIT=true
        NOTREECHECKS=true
        R=hablich@chromium.org

        Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
        Change-Id: Ia9946e28ce41dee6199fac571274aa196576385b
        Reviewed-on: https://chromium-review.googlesource.com/616283
        Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
        Cr-Commit-Position: refs/branch-heads/6.1@{#47}
        Cr-Branched-From: 1bf2e10ddb194d4c2871a87a4732613419de892d-refs/heads/6.1.534@{#1}
        Cr-Branched-From: e825c4318eb2065ffdf9044aa6a5278635c36427-refs/heads/master@{#46746}

    v8: work around callback typedef renaming

    Do some clever tricks to have an easy way around
    V8 renaming one of its typedef to a deprecated version and then
    introducing a new typedef with the same name.

    deps: revert 5ebd6fcd269de from V8 upstream

    Original commit message:

        [heap] Lower external allocation limit when external memory shrinks.

        BUG=chromium:728228
        CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

        Review-Url: https://codereview.chromium.org/2921883002
        Cr-Commit-Position: refs/heads/master@{#45726}

    deps: revert cf8f7bdc9d5ee from V8 upstream

    Original commit message:

        [heap] Increase memory reducer activation limit for external memory changes.

        BUG=chromium:729521
        CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

        Review-Url: https://codereview.chromium.org/2923563006
        Cr-Commit-Position: refs/heads/master@{#45763}

    deps: revert 11fc9fab94d48 from V8 upstream

    Original commit message:

        [heap] Guard against re-entering GC on external memory change.

        TBR=hpayer@chromium.org
        BUG=chromium:729868,chromium:729521
        CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

        Review-Url: https://codereview.chromium.org/2929463002
        Cr-Commit-Position: refs/heads/master@{#45745}

    deps: revert 502c6ae6a0397 from V8 upstream

    Original commit message:

        [heap] Activate memory reducer on external memory activity.

        BUG=chromium:728228,chromium:626082
        CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_rel_ng

        Review-Url: https://codereview.chromium.org/2917853004
        Cr-Commit-Position: refs/heads/master@{#45671}

    v8: revert changes to Contents structs

    The feature is disabled by default anyway,but we disable it completely.

Backport-PR-URL: #15393
PR-URL: #15393
Author: Anna Henningsen <anna@addaleax.net>
Author: Peter Marshall <p.s.marshall0@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Original commit message:

    [heap] Move gc callbacks from List to std::vector

    Bug: v8:6333
    Change-Id: I4434c6cc59f886f1e37dfd315a3ad5fee28d3f63
    Reviewed-on: https://chromium-review.googlesource.com/634907
    Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47601}

PR-URL: #15391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Original commit message:

    [api] Add optional data pointer to GC callbacks

    This can be useful when there may be multiple callbacks attached by
    code that's not directly tied to a single isolate, e.g. working
    on a per-context basis.

    This also allows rephrasing the global non-isolate APIs in terms
    of this new API, rather than working around it inside `src/heap`.

    TBR=hpayer@chromium.org

    Bug:
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I2e490ec40d1a34ea812f25f41ef9741d2116d965
    Reviewed-on: https://chromium-review.googlesource.com/647548
    Reviewed-by: Yang Guo <yangguo@chromium.org>
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47923}

PR-URL: #15391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Currently, measuring GC timing using `node_perf` is somewhat broken,
because Isolates and Node Environments do not necessarily match 1:1;
each environment adds its own hook, so possibly the hook code runs
multiple times, but since it can’t reliably compute its corresponding
event loop based on the Isolate, each run targets the same Environment
right now.

This fixes that problem by using new overloads of the GC tracking
APIs that can pass data to the callback through opaque pointers.

PR-URL: #15391
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
The following deprecation warning is displayed when compiling:

../src/module_wrap.cc:187:18: warning: 'Instantiate' is deprecated
[-Wdeprecated-declarations]
  bool ok = mod->Instantiate(ctx, ModuleWrap::ResolveCallback);
                 ^
../deps/v8/include/v8.h:1158:22: note: 'Instantiate' has been explicitly
marked deprecated here
                bool Instantiate(Local<Context> context,
                     ^

This commit changes this function call to use InstantiateModule instead
which returns a Maybe<bool>.

PR-URL: #15423
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fix CHECKED_RETURN, RESOURCE_LEAK) and UNINIT Coverity warnings in
MarkGarbageCollectionEnd().

PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #15458
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #15551
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Turning FIPS mode on (or off) when it's already on (or off) should be a
no-op, not an error.

PR-URL: #12210
Fixes: #11849
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
The headers node_trace_writer.h and node_trace_buffer.h are not used in
agent.h but are more of an implementation detail of agent.cc.

This commit suggests moving the inclusion of these headers to agent.cc.

PR-URL: #15598
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The `countdown` and `fixtures` modules are documented in the
`common/README.md` file but are omitted from the table of contents. Add
them.

PR-URL: #15595
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joyeecheung and others added 11 commits October 11, 2017 02:06
PR-URL: #16079
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
PR-URL: #16037
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #15782
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #16017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
PR-URL: #16108
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
PR-URL: #16019
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Lance Ball <lball@redhat.com>
PR-URL: #15943
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #15997
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #15838
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Replace string concatenation in `tools/lint-js.js` with template
literals.

PR-URL: #15858
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #15819
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins added a commit that referenced this pull request Oct 11, 2017
Notable Changes:

Coming Soon

PR-URL: #15762
@MylesBorins
Copy link
Contributor Author

Notable Changes:

* deps:
  * update npm to 5.4.2
    #15600
  * upgrade libuv to 1.15.0
    #15745
  * update V8 to 6.1.534.42
    #15393
* dgram:
  * support for setting dgram socket buffer size
    #13623
* fs:
  * add support O_DSYNC file open constant
    #15451
* util:
  * deprecate obj.inspect for custom inspection
    #15631
* tools, build:
  * there is a fancy new macOS installer
    #15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: #15762
@mhdawson
Copy link
Member

The discussion in the TSC meeting is that we'd go with option 1

Land 6.1 with escape analysis disabled

Unless there are objections in this thread.

@bricss
Copy link

bricss commented Oct 11, 2017

@mhdawson And then V8 6.2 will land before LTS?

@MylesBorins
Copy link
Contributor Author

MylesBorins commented Oct 11, 2017 via email

@mhdawson
Copy link
Member

mhdawson commented Oct 11, 2017

@bricss as @MylesBorins says we will revsist when 6.2 is ready and that may be after LTS.

@MylesBorins
Copy link
Contributor Author

If there are no -1s I'm going to go ahead and release this at 4:30 pm EST

@MylesBorins MylesBorins merged commit dc4f1b9 into v8.x Oct 11, 2017
MylesBorins added a commit that referenced this pull request Oct 11, 2017
MylesBorins added a commit that referenced this pull request Oct 11, 2017
Notable Changes:

* deps:
  * update npm to 5.4.2
    #15600
  * upgrade libuv to 1.15.0
    #15745
  * update V8 to 6.1.534.42
    #15393
* dgram:
  * support for setting dgram socket buffer size
    #13623
* fs:
  * add support O_DSYNC file open constant
    #15451
* util:
  * deprecate obj.inspect for custom inspection
    #15631
* tools, build:
  * there is a fancy new macOS installer
    #15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: #15762
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
Notable Changes:

* deps:
  * update npm to 5.4.2
    nodejs/node#15600
  * upgrade libuv to 1.15.0
    nodejs/node#15745
  * update V8 to 6.1.534.42
    nodejs/node#15393
* dgram:
  * support for setting dgram socket buffer size
    nodejs/node#13623
* fs:
  * add support O_DSYNC file open constant
    nodejs/node#15451
* util:
  * deprecate obj.inspect for custom inspection
    nodejs/node#15631
* tools, build:
  * there is a fancy new macOS installer
    nodejs/node#15179
* Added new collaborator
  * bmeurer - Benedikt Meurer - https://github.com/bmeurer
  * kfarnung - Kyle Farnung - https://github.com/kfarnung

PR-URL: nodejs/node#15762
@gibfahn gibfahn deleted the v8.7.0-proposal branch October 12, 2017 19:12
@Trott
Copy link
Member

Trott commented Oct 22, 2017

Since this was released, I imagine the tsc-agenda can be removed. In any event, closed issues are ignored by our tooling and this won't be picked up anyway, so if anyone wants this on the agenda, they'll have to say so in the meeting issue when it's opened anyway.

So I'm removing the label. :-D

@Trott Trott removed the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Oct 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.