🎨 test: replace common.fixturesDir in test-exception.js #15964
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
inspector
Trott
added
the
code-and-learn
BridgeAR
approved these changes
Oct 7, 2017
tniessen
approved these changes
Oct 7, 2017
gibfahn
approved these changes
Oct 7, 2017
targos
approved these changes
Oct 7, 2017
|
Linter failed: not ok 8 - /usr/home/iojs/build/workspace/node-test-linter/test/inspector/test-exception.js
---
message: '''path'' is assigned a value but never used.'
severity: error
data:
line: 9
column: 7
ruleId: no-unused-vars
...Running |
|
@gibfahn thanks for |
addaleax
approved these changes
Oct 7, 2017
Replace common.fixturesDir with usage of the common.fixtures module in text-exception.js
Fix linter error on unused variable.
|
Landing... |
|
Landed in e14fd57 Congratulations on becoming a contributor @chowdhurian ! |
gibfahn
pushed a commit
that referenced
this pull request
Oct 7, 2017
Replace common.fixturesDir with usage of the common.fixtures module in text-exception.js PR-URL: #15964 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Replace common.fixturesDir with usage of the common.fixtures module in text-exception.js PR-URL: #15964 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Replace common.fixturesDir with usage of the common.fixtures module in text-exception.js PR-URL: nodejs/node#15964 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace common.fixturesDir with usage of the common.fixtures module in text-exception.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)