Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update es-module.status prefix #15690

Closed
wants to merge 1 commit into from
Closed

test: update es-module.status prefix #15690

wants to merge 1 commit into from

Conversation

jackhorton
Copy link
Contributor

We noticed this error while taking in changes for node-chakracore.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Sep 29, 2017
@mscdex mscdex added the esm Issues and PRs related to the ECMAScript Modules implementation. label Sep 29, 2017
Trott
Trott approved these changes Sep 30, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This shouldn't need to wait the full 72 hours before landing IMO.

@Trott
Copy link
Member

Trott commented Sep 30, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10351/

@TimothyGu
Copy link
Member

TimothyGu commented Sep 30, 2017 •
edited
Loading

My bad. Thanks for taking care of this!

jasnell
jasnell approved these changes Oct 1, 2017
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure this needs to wait the 48 hours to land

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 1, 2017
@jackhorton @Trott
test: update es-module.status prefix
0880293 
PR-URL: nodejs#15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 1, 2017

Landed in 0880293. Thanks for the fix!

@Trott Trott closed this Oct 1, 2017
@jackhorton jackhorton deleted the es-module-status branch October 2, 2017 06:53
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jackhorton @MylesBorins
test: update es-module.status prefix
1604eb7 
PR-URL: #15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@jackhorton @MylesBorins
test: update es-module.status prefix
c59b070 
PR-URL: #15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@jackhorton @addaleax
test: update es-module.status prefix
93cd76f 
PR-URL: nodejs/node#15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@jackhorton @MylesBorins
test: update es-module.status prefix
803d5bb 
PR-URL: #15690
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
esm Issues and PRs related to the ECMAScript Modules implementation. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@jackhorton @Trott @TimothyGu @jasnell @lpinca @mscdex @MylesBorins @nodejs-github-bot