Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: update test to use fixtures module #15955

Closed
wants to merge 1 commit into from
Closed

test: update test to use fixtures module #15955

wants to merge 1 commit into from

Conversation

gbugaisky
Copy link
Contributor

Updated the test-http2-create-client-connect tests to
use the test fixures module instead of the common
module.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@gbugaisky
test: update test to use fixtures module
02242d7 
Updated the test-http2-create-client-connect tests to
use the test fixures module instead of the common
module.
@tniessen
Copy link
Member

tniessen commented Oct 6, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10430/

@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@joyeecheung
Copy link
Member

Landed in 5ca1c7a, thanks for the contribution and welcome to Node.js!

@joyeecheung joyeecheung closed this Oct 8, 2017
joyeecheung pushed a commit that referenced this pull request Oct 8, 2017
@gbugaisky @joyeecheung
test: update test to use fixtures module
5ca1c7a 
Updated the test-http2-create-client-connect tests to
use the test fixures module instead of the common
module.

PR-URL: #15955
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@gbugaisky @MylesBorins
test: update test to use fixtures module
de198a9 
Updated the test-http2-create-client-connect tests to
use the test fixures module instead of the common
module.

PR-URL: #15955
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@gbugaisky @addaleax
test: update test to use fixtures module
2d18536 
Updated the test-http2-create-client-connect tests to
use the test fixures module instead of the common
module.

PR-URL: nodejs/node#15955
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.