Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async_hooks: fix reference in code comment #15748

Closed
wants to merge 1 commit into from
Closed

async_hooks: fix reference in code comment #15748

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Oct 3, 2017 •
edited
Loading

Lint: https://ci.nodejs.org/job/node-test-linter/12196/

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • async_hooks

@mscdex mscdex added the async_hooks Issues and PRs related to the async hooks subsystem. label Oct 3, 2017
@addaleax
Copy link
Member

addaleax commented Oct 3, 2017

Landed in 7cff6e8

@addaleax addaleax closed this Oct 3, 2017
addaleax pushed a commit that referenced this pull request Oct 3, 2017
@mscdex @addaleax
async_hooks: fix reference in code comment
7cff6e8 
PR-URL: #15748
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
@mscdex mscdex deleted the async-hooks-fix-comment branch October 3, 2017 13:32
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@mscdex @MylesBorins
async_hooks: fix reference in code comment
ff4d0e2 
PR-URL: #15748
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@mscdex @MylesBorins
async_hooks: fix reference in code comment
da7c87f 
PR-URL: #15748
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@mscdex @addaleax
async_hooks: fix reference in code comment
f83ab8e 
PR-URL: nodejs/node#15748
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@mscdex @MylesBorins
async_hooks: fix reference in code comment
16bdbb9 
PR-URL: #15748
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@AndreasMadsen AndreasMadsen AndreasMadsen approved these changes

Assignees
No one assigned
Labels
async_hooks Issues and PRs related to the async hooks subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mscdex @addaleax @AndreasMadsen @lpinca @cjihrig @MylesBorins