Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix http2 API docs typos #15778

Closed
wants to merge 1 commit into from
Closed

Fix http2 API docs typos #15778

wants to merge 1 commit into from

Conversation

sericaia
Copy link
Contributor

@sericaia sericaia commented Oct 5, 2017 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Oct 5, 2017
@joyeecheung
Copy link
Member

joyeecheung commented Oct 7, 2017 •
edited
Loading

Landed in ce49034, thank you and welcome to Node.js!

@joyeecheung joyeecheung closed this Oct 7, 2017
joyeecheung pushed a commit that referenced this pull request Oct 7, 2017
@sericaia @joyeecheung
doc: fix http2 API docs typos
ce49034 
PR-URL: #15778
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
@sericaia @MylesBorins
doc: fix http2 API docs typos
b9866f0 
PR-URL: #15778
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 7, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@sericaia @MylesBorins
doc: fix http2 API docs typos
acd4924 
PR-URL: #15778
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@sericaia sericaia deleted the patch-1 branch October 11, 2017 09:01
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@sericaia @addaleax
doc: fix http2 API docs typos
d649b3f 
PR-URL: nodejs/node#15778
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joyeecheung joyeecheung joyeecheung approved these changes

@cjihrig cjihrig cjihrig approved these changes

@bengl bengl bengl approved these changes

@lance lance lance approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sericaia @joyeecheung @lance @bengl @cjihrig @MylesBorins @nodejs-github-bot