test: improve asset msg in test-zlib-from-gzip-with-trailing-garbage.js #15918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add result to part of assert message.
Trott
added
the
code-and-learn
BridgeAR
approved these changes
Oct 9, 2017
BridgeAR
reviewed
Oct 9, 2017
| @@ -19,7 +19,7 @@ zlib.gunzip(data, common.mustCall((err, result) => { | |||
| assert.strictEqual( | |||
| result.toString(), | |||
| 'abcdef', | |||
| 'result should match original string' | |||
| `result '${result.toString()}' should match original string` | |||
There was a problem hiding this comment.
The best would probably be to just remove the message overall, since we still do not know what "the original string" is.
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
Add result to part of assert message. PR-URL: #15918 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in c80d9d6 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Add result to part of assert message. PR-URL: #15918 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Add result to part of assert message. PR-URL: nodejs/node#15918 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
Add result to part of assert message. PR-URL: #15918 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 18, 2017
Add result to part of assert message. PR-URL: #15918 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
Add result to part of assert message. PR-URL: #15918 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
N/A