Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replaced common.fixturesDir usage in http2-respond-file-push test #15823

Closed
wants to merge 1 commit into from
Closed

test: replaced common.fixturesDir usage in http2-respond-file-push test #15823

wants to merge 1 commit into from

Conversation

ctdio
Copy link
Contributor

@ctdio ctdio commented Oct 6, 2017

Replaces the usage of common.fixturesDir with fixtures.path. I didn't bother using fixtures.readFileSync since the file name was needed for fs.statSync and fs.openSync.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
rmg
rmg approved these changes Oct 6, 2017
View reviewed changes
Copy link
Contributor

@rmg rmg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution!

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@mscdex mscdex added the http2 Issues or PRs related to the http2 subsystem. label Oct 6, 2017
@danbev danbev self-assigned this Oct 9, 2017
danbev pushed a commit to danbev/node that referenced this pull request Oct 9, 2017
@ctdio @danbev
test: replace fixtureDir with fixtures module
56c0e7d 
This commit replaces the usage of common.fixturesDir with
fixtures.path.

PR-URL: nodejs#15823
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danbev
Copy link
Contributor

danbev commented Oct 9, 2017

Landed in 56c0e7d. Thanks!

@danbev danbev closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@ctdio @MylesBorins
test: replace fixtureDir with fixtures module
5bfc4f5 
This commit replaces the usage of common.fixturesDir with
fixtures.path.

PR-URL: #15823
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@ctdio @addaleax
test: replace fixtureDir with fixtures module
04520ec 
This commit replaces the usage of common.fixturesDir with
fixtures.path.

PR-URL: nodejs/node#15823
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@tniessen tniessen tniessen approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@rmg rmg rmg approved these changes

Assignees

@danbev danbev

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.