doc: document the benchmark CI #16086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsemozhetbyt
reviewed
Oct 8, 2017
| ### Running Benchmarks on the CI | ||
|
|
||
| To see the performance impact of a Pull Request by running benchmarks on | ||
| the CI, check out [How to: Running core benchmarks on Node.js CI](benchmark-ci). |
There was a problem hiding this comment.
This link is 404. [How to: Running core benchmarks on Node.js CI][benchmark-ci]?
vsemozhetbyt
approved these changes
Oct 8, 2017
gibfahn
approved these changes
Oct 8, 2017
joyeecheung
force-pushed
the
doc-bench-ci
branch
from
aa4c9f2 to
6a889c5
Compare
|
Landed in 0a64a6a with @vsemozhetbyt's nits fixed. Thanks! |
joyeecheung
added a commit
that referenced
this pull request
Oct 9, 2017
PR-URL: #16086 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #16086 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#16086 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
|
I don't think this is up to date for v6.x. Please lmk if I am mistaken |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc