Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced fixturesDir with common.fixtures module #16051

Closed
wants to merge 2 commits into from
Closed

Replaced fixturesDir with common.fixtures module #16051

wants to merge 2 commits into from

Conversation

rachelnicole
Copy link
Contributor

@rachelnicole rachelnicole commented Oct 6, 2017 •
edited by BridgeAR
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10431/

@joyeecheung
Copy link
Member

joyeecheung commented Oct 6, 2017 •
edited
Loading

Ah, pressed the approval button too early, the commit message is missing subsytem labels. I guess whoever lands this can change the commit message to something like test: replace fixturesDir with common.fixtures instead.

Trott
Trott reviewed Oct 6, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Oct 6, 2017
@refack
Copy link
Contributor

refack commented Oct 6, 2017

Welcome to the dark side @rachelnicole 😉. Hope C&L was fun.

Besides the commit message there's also a list error:

not ok 10 - /usr/home/iojs/build/workspace/node-test-linter/test/parallel/test-internal-modules.js
  ---
  message: '''path'' is assigned a value but never used.'
  severity: error
  data:
    line: 4
    column: 7
    ruleId: no-unused-vars
  ...

This can also be fixed by whomever lands this.
Otherwise I believe the CI is clean.

@refack refack self-assigned this Oct 6, 2017
@rachelnicole
Copy link
Contributor Author

@refack I can totally remove the reference to path and push it up if that's easier!

@refack
Copy link
Contributor

refack commented Oct 6, 2017

@refack I can totally remove the reference to path and push it up if that's easier!

Follow up by the OP is always appreciated, thank you. 🥇

@refack
Copy link
Contributor

refack commented Oct 6, 2017

P.S. you can also locally run make jslint or even node tools/eslint/bin/eslint.js --rulesdir=tools/eslint-rules test/parallel/test-internal-modules.js to make sure you didn't miss any of the other linting rules.

@rachelnicole
Copy link
Contributor Author

@refack i'm on windows and neither of those things worked. D: i might be missing some stuff

@refack
Copy link
Contributor

refack commented Oct 6, 2017

Ohh yeah us Windows devs need to do things a little different (vcbuild nobuild noprojgen lint).
But anyway a new CI linter came back clean - https://ci.nodejs.org/job/node-test-linter/12268.
So this is all set to go 💯 (just need to tweak the commit message while landing).

@joyeecheung
Copy link
Member

Last CI before landing: https://ci.nodejs.org/job/node-test-pull-request/10476/

@refack refack removed their assignment Oct 7, 2017
@joyeecheung
Copy link
Member

Landed in bdf711d, thanks for the contribution!

joyeecheung pushed a commit that referenced this pull request Oct 8, 2017
@rachelnicole @joyeecheung
test: replace fixturesDir with common.fixtures
bdf711d 
PR-URL: #16051
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@Trott Trott closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@rachelnicole @MylesBorins
test: replace fixturesDir with common.fixtures
7ca02b0 
PR-URL: #16051
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@rachelnicole @addaleax
test: replace fixturesDir with common.fixtures
d15c4f8 
PR-URL: nodejs/node#16051
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@rachelnicole @MylesBorins
test: replace fixturesDir with common.fixtures
2698f67 
PR-URL: #16051
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@rachelnicole @MylesBorins
test: replace fixturesDir with common.fixtures
c65d7c1 
PR-URL: #16051
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@rachelnicole @MylesBorins
test: replace fixturesDir with common.fixtures
8c5b51d 
PR-URL: #16051
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@BridgeAR BridgeAR BridgeAR approved these changes

@richardlau richardlau richardlau approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@rachelnicole @joyeecheung @refack @Trott @richardlau @BridgeAR @mscdex @MylesBorins @nodejs-github-bot