-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: added a clearer setup stop point for newer contributers #15962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated console example to follow style of rest of the examples
nodejs-github-bot
added
build
Issues and PRs related to build files or the CI.
doc
Issues and PRs related to the documentations.
labels
Oct 6, 2017
Trott
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Oct 6, 2017
BridgeAR
approved these changes
Oct 7, 2017
addaleax
approved these changes
Oct 7, 2017
targos
approved these changes
Oct 7, 2017
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 8, 2017
Updated console example to follow style of rest of the examples PR-URL: nodejs#15962 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Landed in 3f26340 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
Updated console example to follow style of rest of the examples PR-URL: #15962 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
Updated console example to follow style of rest of the examples PR-URL: nodejs/node#15962 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 17, 2017
Updated console example to follow style of rest of the examples PR-URL: #15962 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 18, 2017
Updated console example to follow style of rest of the examples PR-URL: #15962 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
Updated console example to follow style of rest of the examples PR-URL: #15962 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
build
Issues and PRs related to build files or the CI.
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated console example to follow style of rest of the examples
Checklist
Affected core subsystem(s)
documentation
Feels