Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: remove unused computation #15593

Merged
merged 1 commit into from
Sep 27, 2017
Merged

src: remove unused computation #15593

merged 1 commit into from
Sep 27, 2017

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Sep 24, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Sep 24, 2017
@TimothyGu
Copy link
Member

I'd be okay for this to be squashed into #15592 FYI.

@cjihrig
Copy link
Contributor Author

cjihrig commented Sep 25, 2017

I elected to keep them separate because #15592 fixes an actual compiler warning, while this is just a little clean up.

@jasnell
Copy link
Member

jasnell commented Sep 26, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10279/

@rmisev rmisev mentioned this pull request Sep 27, 2017
Closed
3 tasks
@cjihrig
src: remove unused computation
75ab1e0 
PR-URL: nodejs#15593
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 75ab1e0 into nodejs:master Sep 27, 2017
@cjihrig cjihrig deleted the loop-var branch September 27, 2017 11:55
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Sep 28, 2017
@cjihrig @MylesBorins
src: remove unused computation
ccd00ae 
PR-URL: nodejs#15593
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@cjihrig @MylesBorins
src: remove unused computation
9d2ab20 
PR-URL: #15593
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@cjihrig @addaleax
src: remove unused computation
fe2f271 
PR-URL: nodejs/node#15593
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@cjihrig @MylesBorins
src: remove unused computation
9fcf5d7 
PR-URL: #15593
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @TimothyGu @jasnell @addaleax @lpinca @richardlau @nodejs-github-bot