Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: change encoding to decoding #15706

Closed
wants to merge 1 commit into from
Closed

doc: change encoding to decoding #15706

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

As per the example, querystring.parse actually does URL decoding, not
encoding.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@thefourtheye
doc: change encoding to decoding
bd6956b 
As per the example, `querystring.parse` actually does URL decoding, not
encoding.
@thefourtheye thefourtheye added the doc Issues and PRs related to the documentations. label Oct 1, 2017
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 1, 2017
TimothyGu
TimothyGu approved these changes Oct 1, 2017
View reviewed changes
doc/api/deprecations.md
@@ -675,7 +675,7 @@ querystring.parse(str, '\n', '=');
```

*Note*: This function is not completely equivalent to `querystring.parse()`. One
difference is that `querystring.parse()` does url encoding:
difference is that `querystring.parse()` does url decoding:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: s/does url/attempts URL/

jasnell pushed a commit that referenced this pull request Oct 2, 2017
@thefourtheye @jasnell
doc: change encoding to decoding
8865542 
As per the example, `querystring.parse` actually does URL decoding, not
encoding.

PR-URL: #15706
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@jasnell
Copy link
Member

jasnell commented Oct 2, 2017

Landed in 8865542

@jasnell jasnell closed this Oct 2, 2017
@thefourtheye thefourtheye deleted the fix-minor-doc-issue branch October 2, 2017 16:06
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@thefourtheye @MylesBorins
doc: change encoding to decoding
db1b305 
As per the example, `querystring.parse` actually does URL decoding, not
encoding.

PR-URL: #15706
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@thefourtheye @MylesBorins
doc: change encoding to decoding
a44036d 
As per the example, `querystring.parse` actually does URL decoding, not
encoding.

PR-URL: #15706
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@thefourtheye @addaleax
doc: change encoding to decoding
677a5e2 
As per the example, `querystring.parse` actually does URL decoding, not
encoding.

PR-URL: nodejs/node#15706
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@thefourtheye @MylesBorins
doc: change encoding to decoding
54a43a6 
As per the example, `querystring.parse` actually does URL decoding, not
encoding.

PR-URL: #15706
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

@addaleax addaleax addaleax approved these changes

@jasnell jasnell jasnell approved these changes

@XadillaX XadillaX Awaiting requested review from XadillaX

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@thefourtheye @jasnell @addaleax @lpinca @TimothyGu @cjihrig @hiroppy @MylesBorins @nodejs-github-bot