Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-bindings and test-debug-end flaky #15747

Closed
wants to merge 1 commit into from
Closed

test: mark test-bindings and test-debug-end flaky #15747

wants to merge 1 commit into from

Conversation

joaocgreis
Copy link
Member

test-bindings and test-debug-end have been failing frequently on Windows. For now, just mark them flaky, this can be reverted when a solution is found.

Ref: #15558

Any objections for fast tracking this?

cc @nodejs/testing @nodejs/v8-inspector

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@joaocgreis joaocgreis added flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Oct 3, 2017
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Oct 3, 2017
Trott
Trott approved these changes Oct 3, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to fast-tracking.

@joaocgreis
Copy link
Member Author

joaocgreis commented Oct 3, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/10390/ (all green)

@refack
Copy link
Contributor

refack commented Oct 3, 2017

I'm landing and putting a calendar reminder to follow up every week.
/cc @eugeneo

@refack
Copy link
Contributor

refack commented Oct 3, 2017

Landed in e00a488

@refack refack closed this Oct 3, 2017
refack pushed a commit that referenced this pull request Oct 3, 2017
@joaocgreis @refack
test: mark test-bindings and test-debug-end flaky
e00a488 
PR-URL: #15747
Refs: #15558
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack
Copy link
Contributor

refack commented Oct 3, 2017

@joaocgreis do we have a VS2017 config for node-stress-single-test?

addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 4, 2017
@joaocgreis @addaleax
test: mark test-bindings and test-debug-end flaky
3cfee3f 
PR-URL: nodejs/node#15747
Refs: nodejs/node#15558
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@joaocgreis
Copy link
Member Author

@refack now we do. No cross compiling support yet, so only Windows 2008R2 and 2012R2. I started some test runs, Windows 2012 does not seem to be affected but 2008 is.

Note: mp and 1p are for multiple and single virtual processor machines, in the past this made a big difference for some tests (concurrency issues tent to appear much more often in 1p, but compiling node is much faster in mp).

MylesBorins pushed a commit that referenced this pull request Oct 7, 2017
@joaocgreis @MylesBorins
test: mark test-bindings and test-debug-end flaky
27c4efd 
PR-URL: #15747
Refs: #15558
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 7, 2017
Merged
@refack
Copy link
Contributor

refack commented Oct 10, 2017

Oy what a mess 100 OK: 0 NOT OK: 100 TOTAL: 100
https://ci.nodejs.org/view/All/job/node-stress-single-test/1441/nodes=win2008r2-mp-vs2017/ (--repeat 100 inspector/test-bindings inspector/test-debug-end)

MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@joaocgreis @MylesBorins
test: mark test-bindings and test-debug-end flaky
af304b2 
PR-URL: #15747
Refs: #15558
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiroppy hiroppy hiroppy approved these changes

@cjihrig cjihrig cjihrig approved these changes

@lpinca lpinca lpinca approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

@refack refack refack approved these changes

Assignees
No one assigned
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@joaocgreis @refack @MylesBorins @jasnell @Trott @lpinca @cjihrig @hiroppy @nodejs-github-bot