Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace common.fixturesDir with fixtures. #15802

Closed
wants to merge 1 commit into from
Closed

test: replace common.fixturesDir with fixtures. #15802

wants to merge 1 commit into from

Conversation

codeviking
Copy link
Contributor

Replaces the use of common.fixturesDir with the generic fixtures
mechanism.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • test

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
richardlau
richardlau reviewed Oct 6, 2017
View reviewed changes
test/parallel/test-fs-write-stream-encoding.js Outdated
const fs = require('fs');
const path = require('path');
const stream = require('stream');
const firstEncoding = 'base64';
const secondEncoding = 'latin1';

const examplePath = path.join(common.fixturesDir, 'x.txt');
const examplePath = path.join(fixtures.fixturesDir, 'x.txt');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could alternatively be fixtures.path('x.txt').

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Great. That seems better. I'll tweak that shortly.

@codeviking
test: replace common.fixturesDir with fixtures.
65aabc5 
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
@codeviking
Copy link
Contributor Author

@richardlau I updated to use fixtures.path -- thanks for the tip!

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@Trott
Copy link
Member

Trott commented Oct 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10466/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 8, 2017
@codeviking @Trott
test: replace common.fixturesDir with fixtures.
eb08e3e 
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.

PR-URL: nodejs#15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Oct 8, 2017

Landed in eb08e3e.
Thanks for the contribution! 🎉

@Trott Trott closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@codeviking @MylesBorins
test: replace common.fixturesDir with fixtures.
73a41cf 
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.

PR-URL: #15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@codeviking @addaleax
test: replace common.fixturesDir with fixtures.
800c542 
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.

PR-URL: nodejs/node#15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
@codeviking @MylesBorins
test: replace common.fixturesDir with fixtures.
5b931d7 
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.

PR-URL: #15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@codeviking @MylesBorins
test: replace common.fixturesDir with fixtures.
cbf0d62 
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.

PR-URL: #15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@codeviking @MylesBorins
test: replace common.fixturesDir with fixtures.
4005ed6 
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.

PR-URL: #15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@codeviking @Trott @cjihrig @richardlau @gireeshpunathil @mscdex @MylesBorins @nodejs-github-bot