Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: limit regress/regress-crbug-514081 v8 test #6678

Closed
wants to merge 1 commit into from
Closed

deps: limit regress/regress-crbug-514081 v8 test #6678

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented May 10, 2016 •
edited
Loading

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

deps/v8

Description of change

regress/regress-crbug-514081 allocates a 2G block of memory
and if there are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory. This patch
limits us to running a single variant of the test

Addresses: #6340

@mhdawson
deps: limit regress/regress-crbug-514081 v8 test
363594f 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test
@nodejs-github-bot nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label May 10, 2016
@mhdawson mhdawson self-assigned this May 10, 2016
@mhdawson
Copy link
Member Author

@nodejs/v8

This was referenced May 10, 2016
Merged
Closed
@bnoordhuis
Copy link
Member

LGTM for want of a better solution.

@indutny
Copy link
Member

indutny commented May 11, 2016

LGTM

1 similar comment
@jasnell
Copy link
Member

jasnell commented May 11, 2016

LGTM

@mhdawson
Copy link
Member Author

CI run https://ci.nodejs.org/job/node-test-pull-request/2591/

@mhdawson
Copy link
Member Author

CI is clean except for centos failure that also existing in previous run

@mhdawson
Copy link
Member Author

Will and tomorrow unless there are any objections before then

mhdawson added a commit that referenced this pull request May 12, 2016
@mhdawson
deps: limit regress/regress-crbug-514081 v8 test
2d524bc 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
PR-URL: #6678
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@mhdawson
Copy link
Member Author

Landed as 2d524bc

@mhdawson mhdawson closed this May 12, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@mhdawson @evanlucas
deps: limit regress/regress-crbug-514081 v8 test
16159c2 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
PR-URL: #6678
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
@MylesBorins
Copy link
Contributor

@mhdawson I'm assuming this is v8 5 specific... please feel free to update if this should be backported

ofrobots pushed a commit to ofrobots/node that referenced this pull request Aug 25, 2016
@mhdawson @ofrobots
deps: limit regress/regress-crbug-514081 v8 test
7af2f63 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs#6340
PR-URL: nodejs#6678
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@evanlucas evanlucas mentioned this pull request Aug 26, 2016
Merged
@mhdawson mhdawson mentioned this pull request Oct 3, 2016
Closed
mhdawson added a commit to mhdawson/io.js that referenced this pull request Oct 3, 2016
@mhdawson
deps: v8 - cherry-pick missing v8 floating patch
1f295f8 
2d524bc

Original commit message:

deps: limit regress/regress-crbug-514081 v8 test

regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs#6340
PR-URL: nodejs#6678
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@mhdawson mhdawson mentioned this pull request Oct 3, 2016
Closed
2 tasks
mhdawson added a commit that referenced this pull request Oct 5, 2016
@mhdawson
deps: cherry-pick missing v8 floating patch
4b3e4d5 
2d524bc

Original commit message:

  deps: limit regress/regress-crbug-514081 v8 test

  regress/regress-crbug-514081 allocates a 2G block of memory
  and if there  are multiple variants running at the
  same time this can lead to crashes, OOM kills or
  the OS failing to allocate memory.  This patch
  limits us to running a single variant of the test

  Fixes: #6340
  PR-URL: #6678
  Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  Reviewed-By: James M Snell <jasnell@gmail.com>
  Reviewed-By: Fedor Indutny <fedor@indutny.com>

PR-URL: #8907
Fixes: #8750
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 1, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
6c1d816 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 2, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
be1d08f 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 3, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
ee1925c 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 4, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
32963b2 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 5, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
4c26d86 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 6, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
2d11af3 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 6, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
4325d44 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 7, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
abb8514 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 8, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
be2f1ab 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 9, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
8e5dced 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 10, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
b0be3ca 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 11, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
174e876 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 12, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
82b7b6c 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
targos pushed a commit to targos/node that referenced this pull request Sep 12, 2017
@mhdawson @targos
deps: limit regress/regress-crbug-514081 v8 test
55f5603 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs#6340
PR-URL: nodejs#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 13, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
7cd8c20 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
addaleax pushed a commit that referenced this pull request Sep 13, 2017
@mhdawson @addaleax
deps: limit regress/regress-crbug-514081 v8 test
c6e165b 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
PR-URL: #6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@mhdawson @addaleax
deps: limit regress/regress-crbug-514081 v8 test
6a7017c 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs#6340
PR-URL: nodejs#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
nodejs-ci pushed a commit to nodejs/node-v8 that referenced this pull request Sep 14, 2017
@mhdawson @nodejs-ci
deps: limit regress/regress-crbug-514081 v8 test
7da10b7 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs/node#6340
PR-URL: nodejs/node#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
targos pushed a commit to targos/node that referenced this pull request Sep 14, 2017
@mhdawson @targos
deps: limit regress/regress-crbug-514081 v8 test
e52f755 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs#6340
PR-URL: nodejs#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
targos pushed a commit to targos/node that referenced this pull request Sep 21, 2017
@mhdawson @targos
deps: limit regress/regress-crbug-514081 v8 test
cbd1cb7 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: nodejs#6340
PR-URL: nodejs#6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2017
@mhdawson @MylesBorins
deps: limit regress/regress-crbug-514081 v8 test
97828b2 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
Backport-PR-URL: #15393
PR-URL: #6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@mhdawson @MylesBorins
deps: limit regress/regress-crbug-514081 v8 test
e04b70a 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
Backport-PR-URL: #15393
PR-URL: #6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@mhdawson @MylesBorins
deps: limit regress/regress-crbug-514081 v8 test
21004dd 
regress/regress-crbug-514081 allocates a 2G block of memory
and if there  are multiple variants running at the
same time this can lead to crashes, OOM kills or
the OS failing to allocate memory.  This patch
limits us to running a single variant of the test

Fixes: #6340
Backport-PR-URL: #15393
PR-URL: #6678
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhdawson mhdawson

Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mhdawson @bnoordhuis @indutny @jasnell @MylesBorins @nodejs-github-bot