Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: use common.fixtures module #15891

Closed
wants to merge 1 commit into from
Closed

test: use common.fixtures module #15891

wants to merge 1 commit into from

Conversation

cjchoi
Copy link
Contributor

@cjchoi cjchoi commented Oct 6, 2017

  • replace common.fixturesDir with usage of the common.fixtures module
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@cjchoi
test: use common.fixtures module
1c5792b 
- replace common.fixturesDir with usage of the common.fixtures module
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 6, 2017
@Trott Trott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@Trott
Copy link
Member

Trott commented Oct 8, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/10508/

@Trott Trott self-assigned this Oct 9, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Oct 9, 2017
@cjchoi @Trott
test: use common.fixtures module
b5e8ae4 
Replace common.fixturesDir with usage of the common.fixtures module.

PR-URL: nodejs#15891
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@Trott
Copy link
Member

Trott commented Oct 9, 2017

Landed in b5e8ae4.
Thanks for the contribution! 🎉

@Trott Trott closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@cjchoi @MylesBorins
test: use common.fixtures module
d3272c4 
Replace common.fixturesDir with usage of the common.fixtures module.

PR-URL: #15891
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@cjchoi @addaleax
test: use common.fixtures module
be9c10f 
Replace common.fixturesDir with usage of the common.fixtures module.

PR-URL: nodejs/node#15891
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott approved these changes

@sam-github sam-github sam-github approved these changes

Assignees

@Trott Trott

Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjchoi @Trott @sam-github @BridgeAR @mscdex @MylesBorins @nodejs-github-bot