doc: fix dead link in doc/releases.md #15733
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibfahn
reviewed
Oct 2, 2017
doc/releases.md
Outdated
| @@ -32,7 +32,7 @@ Release builds require manual promotion by an individual with SSH access to the | |||
|
|
|||
| A SHASUMS256.txt file is produced for every promoted build, nightly, and releases. Additionally for releases, this file is signed by the individual responsible for that release. In order to be able to verify downloaded binaries, the public should be able to check that the SHASUMS256.txt file has been signed by someone who has been authorized to create a release. | |||
|
|
|||
| The GPG keys should be fetchable from a known third-party keyserver. The SKS Keyservers at <https://sks-keyservers.net> are recommended. Use the [submission](https://sks-keyservers.net/i/#submit) form to submit a new GPG key. Keys should be fetchable via: | |||
| The GPG keys should be fetchable from a known third-party keyserver. The SKS Keyservers at <https://sks-keyservers.net> are recommended. Use the [submission](http://pgp.mit.edu:11371/#submit) form to submit a new GPG key. Keys should be fetchable via: | |||
There was a problem hiding this comment.
The SKS Keyservers at https://sks-keyservers.net are recommended.
Should this part be changed?
There was a problem hiding this comment.
I think it's fine. The MIT server is in the pool.
jasnell
approved these changes
Oct 2, 2017
|
This shouldn't need to wait the 48 hours to land |
gibfahn
approved these changes
Oct 2, 2017
|
Landed in a6b47a2 |
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
PR-URL: nodejs/node#15733 Fixes: nodejs/node#15730 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #15730
Checklist
Affected core subsystem(s)
doc