test: replaced string concat with template literals #15885
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
dont-land-on-v4.x
inspector
Trott
added
the
code-and-learn
cjihrig
reviewed
Oct 7, 2017
| @@ -69,8 +69,7 @@ function testSampleDebugSession() { | |||
| actual = v['value']['value']; | |||
| expected = expects[v['name']][i]; | |||
| if (actual !== expected) { | |||
| failures.push('Iteration ' + i + ' variable: ' + v['name'] + | |||
| ' expected: ' + expected + ' actual: ' + actual); | |||
| failures.push(`Iteration ${i} variable: ${v['name']} expected: ${expected} actual: ${actual}`); | |||
There was a problem hiding this comment.
Please wrap lines at 80 characters.
BridgeAR
approved these changes
Oct 9, 2017
| @@ -69,8 +69,7 @@ function testSampleDebugSession() { | |||
| actual = v['value']['value']; | |||
| expected = expects[v['name']][i]; | |||
| if (actual !== expected) { | |||
| failures.push('Iteration ' + i + ' variable: ' + v['name'] + | |||
| ' expected: ' + expected + ' actual: ' + actual); | |||
| failures.push(`Iteration ${i} variable: ${v['name']} expected: ${expected} actual: ${actual}`); | |||
BridgeAR
pushed a commit
that referenced
this pull request
Oct 9, 2017
PR-URL: #15885 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in 506a5f7 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
|
@GitHubTracey you might want to go to 506a5f7 and click the ❔ so that GitHub will know it's yours |
MylesBorins
pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15885 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
addaleax
pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15885 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Thanks, Refael! I have been away from my computer since the event. I
appreciate the direction! Also, thank-you to Ruben for fixing the
line-wrap. When I first committed, I had thought about that, but since we
were trying to get rid of the string concat, I figured I shouldn't do that.
It is understandable though.
Thanks to all of those at the event! it was amazing!
…On Mon, Oct 9, 2017 at 8:29 AM, Refael Ackermann ***@***.***> wrote:
@GitHubTracey <https://github.com/githubtracey> you might want to go to
506a5f7
<506a5f7>
and click the ❔ so that GitHub will know it's yours
[image: image]
<https://user-images.githubusercontent.com/96947/31345742-b80a450a-ace4-11e7-95ce-6c781e279e0e.png>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#15885 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ATBGPpyz5YuUujUPjxtHYIoEBGkBqsS4ks5sqjvpgaJpZM4PwxuH>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replaced string concatenation with template literals
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test