-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add fixtures module #15984
Closed
Closed
test: add fixtures module #15984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated parallel/test-require-resolve.js to use the common.fixtures module
New linter CI: https://ci.nodejs.org/job/node-test-linter/12257/ |
Trott
added
the
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
label
Oct 6, 2017
BridgeAR
approved these changes
Oct 6, 2017
jasnell
approved these changes
Oct 10, 2017
lpinca
approved these changes
Oct 13, 2017
tniessen
approved these changes
Oct 13, 2017
tniessen
pushed a commit
that referenced
this pull request
Oct 13, 2017
Updated parallel/test-require-resolve.js to use the fixtures module. PR-URL: #15984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Landed in b1506f7, thank you for your contribution! 🎉 |
b1506f7 fails on my local Ubuntu setup:
I verified locally that rolling it back fixes regression. |
@eugeneo Does this fix your problem? index 27fb3f71f7..77f07b394f 100644
--- test/parallel/test-require-resolve.js
+++ test/parallel/test-require-resolve.js
@@ -26,7 +26,7 @@ const assert = require('assert');
assert.strictEqual(
fixtures.path('a.js').toLowerCase(),
- require.resolve(fixtures.path('a').toLowerCase()));
+ require.resolve(fixtures.path('a')).toLowerCase());
assert.strictEqual(
fixtures.path('a.js').toLowerCase(),
require.resolve(fixtures.path('a')).toLowerCase()); |
tniessen
added a commit
to tniessen/node
that referenced
this pull request
Oct 13, 2017
2 tasks
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
Updated parallel/test-require-resolve.js to use the fixtures module. PR-URL: nodejs/node#15984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
PR-URL: nodejs/node#16192 Refs: nodejs/node#15984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
Updated parallel/test-require-resolve.js to use the fixtures module. PR-URL: #15984 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
code-and-learn
Issues related to the Code-and-Learn events and PRs submitted during the events.
module
Issues and PRs related to the module subsystem.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced common.fixturesDir with usage of the common.fixtures module
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test