Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix regression in test-require-resolver.js #16192

Closed
wants to merge 1 commit into from
Closed

test: fix regression in test-require-resolver.js #16192

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

I suspect this is the reason for the regression reported here.

Refs: #15984

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@tniessen tniessen added the test Issues and PRs related to the tests. label Oct 13, 2017
@tniessen tniessen self-assigned this Oct 13, 2017
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 13, 2017
@jasnell
Copy link
Member

jasnell commented Oct 13, 2017

+1 for fast tracking this

@mscdex mscdex added the module Issues and PRs related to the module subsystem. label Oct 14, 2017
@tniessen
Copy link
Member Author

Landed in 91a465c.

@tniessen tniessen closed this Oct 14, 2017
tniessen added a commit that referenced this pull request Oct 14, 2017
@tniessen
test: fix regression in test-require-resolver.js
91a465c 
PR-URL: #16192
Refs: #15984
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
@tniessen @addaleax
test: fix regression in test-require-resolver.js
0608636 
PR-URL: nodejs/node#16192
Refs: nodejs/node#15984
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@tniessen @targos
test: fix regression in test-require-resolver.js
816acc9 
PR-URL: #16192
Refs: #15984
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@jasnell jasnell jasnell approved these changes

@eugeneo eugeneo Awaiting requested review from eugeneo

Assignees

@tniessen tniessen

Labels
module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @jasnell @richardlau @mscdex @MylesBorins @nodejs-github-bot