errors: remove ERR_OUTOFMEMORY #17877
Conversation
nodejs-github-bot
added
the
errors
There was a problem hiding this comment.
In general I am fine with this because http2 is still experimental. But we should never remove a error code from now on. Instead, we should deprecate it. The reason is that otherwise people who run into this error code in a older version can not find a proper explanation for it anymore. We night consider adding a specific area for out-dated codes.
|
@BridgeAR While this might generally be true, I don't think it matters in this particular case. The documentation for
+1 if that ever turns out to be necessary. |
|
Landed in a82b1b7. |
PR-URL: #17877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
This does not land cleanly on v9.x, could it be backported? |
PR-URL: nodejs#17877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Should this be backported to |
PR-URL: nodejs#17877 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
The error code
ERR_OUTOFMEMORYwas added in e71e71b and is unused ever since 69e6c5a. Apart from not being used within node core, it is the only error code which does not use underscores to separate words (ERR_OUTOFMEMORYvsERR_OUT_OF_RANGE).Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
errors