v8.11.2 proposal #20478
Merged
v8.11.2 proposal #20478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR-URL: #16251 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
82bdf8f fixed an issue by silently modifying the `start` option for the case when only `end` is passed, in order to perform reads from a specified range in the file. However, that approach does not work for non-seekable files, since a numeric `start` option means that positioned reads will be used to read data from the file. This patch fixes that, and instead ends reading after a specified size by adjusting the read buffer size. This way we avoid re-introducing the bug that 82bdf8f fixed, and align behaviour with the native file stream mechanism introduced in #18936 as well. Backport-PR-URL: #19410 PR-URL: #19329 Fixes: #19240 Refs: #18121 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Chen Gang <gangc.cxy@foxmail.com>
Ensure that the parser is freed before emitting the 'connect' or 'upgrade' event. PR-URL: #18209 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
To avoid a function call `BufferList.prototype.concat()` is not called when there is only a buffer in the list. That buffer is instead accessed directly. PR-URL: #18239 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
The `n` argument of `BufferList.prototype.concat()` is not the number of `Buffer` instances in the list, but their total length when concatenated. PR-URL: #18239 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #18264 Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
PR-URL: #18376 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Fixes: #18434 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
It makes more sense to provide instructions on how to update the PR branch before instructions on pushing the commit. PR-URL: #18355 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
PR-URL: #18468 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Welcome Gibson to the TSC! PR-URL: #18481 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Under some conditions, the error received from getaddrinfo might actually be EAGAIN, meaning the request should be retried. Allowing for 5 retries before erroring out. Also replace one-off function with common.mustNotCall(). PR-URL: #16534 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #18375 Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This test had some unnecessary timeouts that made it run for a much longer time than necessary (about 9 s rather than 0.2 s). PR-URL: #18424 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Weijia Wang <starkwang@126.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #18426 Refs: 719247f Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Highlights: * Using a random port works (`node inspect --port=0 script.js`) * `takeHeapSnapshot()` creates valid snapshots again PR-URL: #18354 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
With some of the recent work, some of the comments were no longer representative of the code, or were otherwise unclear. This commit fixes some obvious issues I found. Ref: 83e5215 Ref: 0784b04 PR-URL: #18467 Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #18482 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Add stack_trace_posix to 'sources' as well. Fixes #15784 Fixes nodejs/help#992 add stack_trace_posix to OpenBSD's sources PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #18448 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Shorten text that is duplicated from website and supply link. PR-URL: #18483 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This resets the StringDecoder's state after calling `#end`. Further writes to the decoder will act as if it were a brand new instance, allowing simple reuse. PR-URL: #18494 Fixes: #16564 Refs: #16594 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #18489 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Useful for executing in a shell because it accepts arguments as an array instead of a string as exec does. Depending on the circumstances, that can prove to be useful if the arguments are already prepared. PR-URL: #18384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
PR-URL: #18289 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Backport-PR-URL: #20456 PR-URL: #19647 Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Chen Gang <gangc.cxy@foxmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Do not close the request if callback is not a function, and throw ERR_INVALID_CALLBACK TypeError Backport-PR-URL: #19229 Backport-PR-URL: #20456 PR-URL: #19061 Fixes: #18855 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Clarify current behavior of http2server.close() and http2secureServer.close() w.r.t. perceived differences when compared with httpServer.close(). Fixes: #19711 Backport-PR-URL: #20456 PR-URL: #19802 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
When a timeout within a list of timeouts (that consists of only that specific timeout) throws during its execution, it's possible for the TimerWrap handle to become shared between both that list and an unref'd timeout created in the future. This fixes the bug by extending error handling in timeout execution to check for whether the current list is empty and if so do cleanup on it. PR-URL: #20497 Fixes: #19970 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
--tag needs to be set after `getnodeversion` because TAG is defined in there when DISTTYPE is not "release", setting it before `getnodeversion` leads to --tag not being passed down in to `configure` and src/node_version.h setting it as `-pre` by default. This change restores the functionality that properly sets the TAG for nightlies, rc builds and other custom build types. Ref: #17299 Ref: nodejs/abi-stable-node#289 PR-URL: #18031 Ref: #17299 Ref: nodejs/abi-stable-node#289 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: JoãReis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
|
@MylesBorins Great! If everything works out, is this version going to be 8.11.2-rc.2, or 8.11.2? |
MylesBorins
force-pushed
the
v8.11.2-proposal
branch
from
d747bc4
to
faf417b
Compare
|
Broke a thing... fixed it... one more CI CI: https://ci.nodejs.org/job/node-test-pull-request/14892/ |
|
@benjamn v8.11.2 will be going out later today |
This was referenced Jun 14, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2018-05-15, Version 8.11.2 'Carbon' (LTS), @MylesBorins
Notable Changes
Commits
ce3866bdcc] - async_hooks: clean up comments (Ali Ijaz Sheikh) #1846786e3c89ea4] - benchmark: improve compare output (Ruben Bridgewater) #1859718be476116] - benchmark: fix punycode test for --without-intl (Timothy Gu) #1625188d3028e22] - build: no longer have v8-debug.h as dependency. (Yang Guo) #186777b6d93c145] - build: add doc linting when runnningmake lint(Camilo Gonzalez) #184729bce14172a] - build: do not suppress output in make doc-only (Joyee Cheung) #18507333d7dda84] - build: make lint-js independent of local node (Joyee Cheung) #18272d537f45aaa] - build: make lint-md independent of local node (Joyee Cheung) #18272658dd409fd] - build: refine static and shared lib build (Yihong Wang) #17604659b2a1821] - build: allow x86_64 as a dest_cpu alias for x64 (Rod Vagg) #18052424703a556] - build: add cflags for OpenBSD, remove stray comma. (Aaron Bieber) #18448674e75d1e9] - build,win: restore vcbuild TAG functionality (Rod Vagg) #18031bf4d0743be] - cluster: fix inspector port assignment (Santiago Gimeno) #1869616bf5fed69] - crypto: reuse variable instead of reevaluation (Tobias Nießen) #177359acc7f3fbb] - deps: update nghttp2 to 1.29.0 (James M Snell) #17908ab005592be] - deps: V8: backport 76c3ac5 from upstream (Ali Ijaz Sheikh) #18298f12db24947] - deps: cherry-pick a803fad from upstream V8 (Michaël Zasso) #1982409f5e252bf] - deps: cherry-pick 7abdadc from upstream V8 (Michaël Zasso) #19824c97237bc10] - deps: cherry-pick a4bddba from upstream V8 (Michaël Zasso) #19824d02b72e799] - deps: V8: backport 596d55a from upstream (Myles Borins) #1947779a7a17312] - deps: update node-inspect to 1.11.3 (Jan Krems) #183541131241d3c] - deps,src: align ssize_t ABI between Node & nghttp2 (Anna Henningsen) #1856529643cc492] - doc: add Http2Session.connecting property (Pieter Mees) #198425989321404] - doc: guard against md list parsing edge case (Vse Mozhet Byt) #1964735d35d70c7] - doc: rename HTTP2 to HTTP/2 (Timothy Gu) #196031f420fc799] - doc: add note about browsers and HTTP/2 (Steven) #19476fe3c85f72f] - doc: fix typo in http2.md (Vse Mozhet Byt) #1887267f9d5df97] - doc: warn against concurrent http2stream.respondWithFD (Anna Henningsen) #1876239267e8bb0] - doc: fix typo in http2.md (Vse Mozhet Byt) #186022da965c5b8] - doc: remove removed apis from http2 docs (Kelvin Jin) #184399a4a8c127e] - doc: unify type linkification (Vse Mozhet Byt) #1840715023c7d28] - doc: fix documentation of http2Stream.pushstream() (Peter Dalgaard-Jensen) #18258fac76f9a6b] - doc: fix typo in http2stream.close param default (Moritz Peters) #1816688babd5a23] - doc: fix s/rstStream/close in example (James M Snell) #18088d9d0d0e98e] - doc: update pushStream docs to use err first (James M Snell) #18088940457394a] - doc: compact eslint directives in common/README (Vse Mozhet Byt) #17971e9de5a976b] - doc: re-alphabetise sections in common/README.md (Vse Mozhet Byt) #17971c924adf33d] - doc: fix code nits in common/README (Vse Mozhet Byt) #179710205b3f0c1] - doc: correct spelling (sreepurnajasti) #17911591f78bb0a] - doc: grammar fixes in http2.md (Rich Trott) #1797235ee8943da] - doc: add docs for common/http2.js utility (James M Snell) #17942f0ba2c6ceb] - doc: Add a missing comma (jiangq) #195557c6fa183cb] - doc: fix typos on n-api (Kyle Robinson Young) #193851abb168838] - doc: fix n-api asynchronous threading docs (Eric Bickle) #1907387d0fd8212] - doc: mark NAPI_AUTO_LENGTH as code (Tobias Nießen) #1869758688d97dc] - doc: fix exporting a function example (Aonghus O Nia) #186614d43607474] - doc: fix typo in n-api.md (Vse Mozhet Byt) #185909729278007] - doc: small typo in n-api.md (iskore) #185557ed1dfef28] - doc: remove usage of you in n-api doc (Michael Dawson) #1852884e0a03727] - doc: remove uannecessary Require (Michael Dawson) #1818451513fdf9e] - doc: napi: make header style consistent (Ali Ijaz Sheikh) #1812202ae3295d5] - doc: napi: fix unbalanced emphasis (Ali Ijaz Sheikh) #1812279ecc2c586] - doc: updates examples to use NULL (Michael Dawson) #18008b2213798a3] - doc: fix MDN links to avoid redirections (Vse Mozhet Byt) #18631f4ddaaec0e] - doc: move Fedor to TSC Emeritus (Myles Borins) #18752b8f2acd2e8] - doc: add mmarchini to collaborators (Matheus Marchini) #1874016f9631475] - doc: add history for url.parse (Steven) #18685d30c3533ff] - doc: fix links to Style Guide and CPP Style Guide (Justin Lee) #18683176ed1e9b1] - doc: add devsnek to collaborators (Gus Caplan) #1867925db460f03] - doc: expand on promises and async_hooks (Ali Ijaz Sheikh) #1854073adadd56a] - doc: add section for strategic initiatives (Michael Dawson) #171048ca6d34801] - doc: add introduce about cli options (Weijia Wang) #184751ea1970c37] - doc: modify the return value of request.write() (陈刚) #1852650bdf0ed78] - doc: be more explicit in the sypnosis (Tim O. Peters) #17977f8ad381e61] - doc: add missing meta for createCipheriv (Tobias Nießen) #186510071560eb4] - doc: fix description of createDecipheriv (Tobias Nießen) #18651c89781583b] - doc: fix various nits (Vse Mozhet Byt) #197431091dfc801] - doc: linkify missing types (Vse Mozhet Byt) #184441107a494e4] - doc: shell option for the execFile and execFileSync functions (jvelezpo) #1823736ea472393] - doc: improve http.request documentation (Guangcong Luo) #18289e5d5137963] - doc: streamline README intro (Rich Trott) #18483eec9334a2e] - doc: move Brian White to TSC Emeriti list (Rich Trott) #18482ac41aacb05] - doc: improve stream documentation (陈刚) #183757feeb1574e] - doc: add Gibson Fahnestock to TSC (Rich Trott) #18481142ad8d450] - doc: reorder section on updating PR branch (Ali Ijaz Sheikh) #1835539ea4f12c5] - doc: fix manpage warnings (Roman Reiss)5209f9e1e2] - doc: warn about GCM authenticity (Tobias Nießen) #18376e84e9db6fe] - doc: capitalize non-primitive types (Vse Mozhet Byt) #1811188d4794263] - doc, http2: add sections for server.close() (Chris Miller) #19802cbc8561949] - errors: remove ERR_OUTOFMEMORY (Tobias Nießen) #178772995506bbf] - fs: fix stack overflow in fs.readdirSync (Joyee Cheung) #18647a653f23dfc] - fs: fixcreateReadStream(…, {end: n})for non-seekable fds (Anna Henningsen) #193296bfdba125f] - http: remove default 'drain' listener on upgrade (Luigi Pinca) #1886629c395d975] - http: allow _httpMessage to be GC'ed (Luigi Pinca) #18865d2a884edf9] - http: fix parsing of binary upgrade response body (Ben Noordhuis) #178061d88266543] - http: free the parser before emitting 'upgrade' (Luigi Pinca) #18209b54452d19e] - http2: emit session connect on next tick (Pieter Mees) #1984282b56b631d] - http2: callback valid check before closing request (Trivikram) #1906158a7fd0720] - http2: destroy() stream, upon errnoException (Sarat Addepalli) #1938991b4167ca6] - http2: remove some unnecessary next ticks (James M Snell) #194517321dd3094] - http2: no stream destroy while its data is on the wire (Anna Henningsen) #190029d59aa84f9] - http2: fix flaky test-http2-https-fallback (Matteo Collina) #19093dc3f6c0859] - http2: fix endless loop when writing empty string (Anna Henningsen) #1892481c08a1824] - http2: use original error for cancelling pending streams (Anna Henningsen) #18988f137c1842e] - http2: send error text in case of ALPN mismatch (Anna Henningsen) #18986cd914cab71] - http2: fix condition where data is lost (Matteo Collina) #18895b895ca90d4] - http2: use\_finalinstead ofon('finish')(Anna Henningsen) #186090aa7698313] - http2: add req and res options to server creation (Peter Marton) #1556058478d8307] - http2: add http fallback options to .createServer (Peter Marton) #15752ac64b4f6a7] - http2: add checks for server close callback (James M Snell) #181828b0a1b32de] - http2: refactor read mechanism (Anna Henningsen) #18030a4d910c644] - http2: remember sent headers (James M Snell) #180453cd205431b] - http2: use aliased buffer for perf stats, add stats (James M Snell) #1802046d1b331e0] - http2: verify flood error and unsolicited frames (James M Snell) #17969a85518ed22] - http2: verify that a dependency cycle may exist (James M Snell) #179689c85ada4e3] - http2: implement maxSessionMemory (James M Snell) #179679a6ea7eb02] - http2: properly handle already closed stream error (James M Snell) #179420078a97793] - http2: add aligned padding strategy (James M Snell) #179381c313e09d6] - http2: add initial support for originSet (James M Snell) #179351a24feccb5] - http2: add altsvc support (James M Snell) #17917c915bc54d4] - http2: strictly limit number on concurrent streams (James M Snell) #16766dcc7f4d84c] - http2: perf_hooks integration (James M Snell) #1790672b42de33a] - http2: implement ref() and unref() on client sessions (Kelvin Jin) #1762055f6bdb698] - http2: keep session objects alive during Http2Scope (Anna Henningsen) #17863c61a54ec3d] - http2: fix compiling with--debug-http2(Anna Henningsen) #1786304632214c1] - http2: convert Http2Settings to an AsyncWrap (James M Snell) #17763ea98fd573e] - http2: refactor outgoing write mechanism (Anna Henningsen) #1771805b823d4ad] - http2: remove redundant write indirection (Anna Henningsen) #17718fc40b7de46] - http2: cleanup Http2Stream/Http2Session destroy (James M Snell) #174061d65f2b879] - http2: be sure to destroy the Http2Stream (James M Snell) #174068431b4297c] - http2: only schedule write when necessary (Anna Henningsen) #1718338cfb707bd] - http2: don't call into JS from GC (Anna Henningsen) #17183a1539e5731] - http2: simplify onSelectPadding (Anna Henningsen) #177179a4bac2081] - http2,perf_hooks: perf state using AliasedBuffer (Kyle Farnung) #183009129bc4fde] - lib: set process.execPath on OpenBSD (Aaron Bieber) #185432019b023a7] - lib: refactor ES module loader for readability (Anna Henningsen) #165793df0570c90] - lib: fix spelling in comments (Tobias Nießen) #1801820844d1716] - lib: remove debugger dead code (Qingyan Li) #1842607a6770614] - n-api: add moreint64\_ttests (Kyle Farnung) #194028b3ef4660a] - n-api: back up env before finalize (Gabriel Schulhof) #1971892f699e021] - n-api: ensure in-module exceptions are propagated (Gabriel Schulhof) #19537367113f5d7] - n-api: bump version of n-api supported (Michael Dawson) #1949724b8bb6708] - n-api: re-write test_make_callback (Gabriel Schulhof) #194483a6b7e610d] - n-api: add napi_fatal_exception (Mathias Buus) #193379949d55ae9] - n-api: separate out async_hooks test (Gabriel Schulhof) #19392f29d8e0e8d] - n-api: add missing exception checking (Michael Dawson) #19362faf94b1c49] - n-api: resolve promise in test (Gabriel Schulhof) #19245df63adf7aa] - n-api: update documentation (Gabriel Schulhof) #19078b26410e86f] - n-api: update reference test (Gabriel Schulhof) #19086cb3f90a1a9] - n-api: fix object test (Gabriel Schulhof) #190399244e1d234] - n-api: remove extra reference from test (Gabriel Schulhof) #18542927fc0b19f] - n-api: add methods to open/close callback scope (Michael Dawson) #18089969a520990] - n-api: wrap control flow macro in do/while (Ben Noordhuis) #18532d89f5937eb] - n-api: implement wrapping using private properties (Gabriel Schulhof) #18311af655f586c] - n-api: change assert ok check to notStrictEqual. (Aaron Kau) #18414ca10fda064] - n-api: throw RangeError napi_create_typedarray() (Jinho Bang) #18037853b4d593c] - n-api: expose n-api version in process.versions (Michael Dawson) #1806748be8a4793] - n-api: throw RangeError in napi_create_dataview() with invalid range (Jinho Bang) #17869a744535f99] - n-api: fix memory leak in napi_async_destroy() (alnyan) #17714584fadc605] - n-api,test: add int64 bounds tests (Kyle Farnung) #193094c1181dc02] - n-api,test: add a new.target test to addons-napi (Taylor Woll) #192363225601ffc] - net: remove Socket.prototoype.read (Anna Henningsen) #1856835aaee1059] - net: remove redundant code from _writeGeneric() (Luigi Pinca) #1842954442efcd2] - perf_hooks: refactor internals (James M Snell) #178226bdfb1f8f0] - perf_hooks,http2: add performance.clear() (James M Snell) #180461faae90b74] - readline: use Date.now() and move test to parallel (Anatoli Papirovski) #18563965b56a34e] - readline: update references to archived repository (Tobias Nießen) #179245dda33fda3] - src: add nullptr check for session in DEBUG macro (Daniel Bevenius) #188154e807d648e] - src: introduce internal buffer slice constructor (Anna Henningsen) #180300b828e5125] - src: remove declarations for missing functions (Anna Henningsen) #181343766e04f31] - src: silence http2 -Wunused-result warnings (cjihrig) #179542b7732788a] - src: add optional keep-alive object to SetImmediate (Anna Henningsen) #17183f3e082c4ea] - src: replace SetAccessor w/ SetAccessorProperty (Jure Triglav) #1766545e28a8628] - src: minor refactoring to StreamBase writes (Anna Henningsen) #1756442b4f3ce0b] - src: fix abort when taking a heap snapshot (Ben Noordhuis) #18898b48ca0a140] - src: fix crypto.pbkdf2 callback error argument (BufoViridis) #18458973488b77b] - src: replace var for let / const. (alejandro estrada) #186499ac91b14de] - src: fix util abort (Ruben Bridgewater) #19224c0f40be23b] - src: free memory before re-setting URLHost value (Ivan Filenko) #183575e4f9b37ba] - src,doc,test: Fix common misspellings (Roman Reiss) #1815110231a9e44] - stream: cleanup() when unpiping all streams. (陈刚) #18266bf523822ba] - stream: simplifysrc.\_readableStatetostate(陈刚) #1826437e594ed4a] - stream: remove unreachable code (Luigi Pinca) #18239f96b0bf494] - string_decoder: reset decoder on end (Justin Ridgewell) #1849442778c3791] - test: http2 errors on req.close() (Trivikram) #18854a77d3fad97] - test: http2 stream.respond() error checks (Trivikram) #18861bac93443d2] - test: check endless loop while writing empty string (XadillaX) #189247eba62e028] - test: make test-tls-external-accessor agnostic (Rich Trott) #162729e68947ff4] - test: add hasCrypto when using binding('crypto') (Daniel Bevenius) #178676129ff4b99] - test: remove unnecessary timer (cjihrig) #187192838f9b150] - test: convert new tests to use error types (Jack Horton) #185815c0983e5a2] - test: improve error message output (Bhavani Shankar) #18498bebcdfe382] - test: show pending exception error in napi tests (Ben Wilcox) #184135b1b74c5a5] - test: refactor addons-napi/test_exception/test.js (Rich Trott) #183408cfa87832d] - test: fixed typos in napi test (furstenheim) #18148ad8c079af7] - test: remove ambiguous error messages from test_error (Nicholas Drane) #178122e100c82be] - test: remove literals that obscure assert messages (Rich Trott) #17642077e1870ae] - test: add unhandled rejection guard (babygoat) #172759236332cc3] - test: update a few tests to work on OpenBSD (Aaron Bieber) #18543cbd698a521] - test: refactor test-http-abort-before-end (cjihrig) #18508ab8edc9d48] - test: fix flaky timers-block-eventloop test (Anatoli Papirovski) #1856753b702fdba] - test: remove common.PORT from parallel tests (Rich Trott) #17410da162278de] - test: mock the lookup function in parallel tests (Joyee Cheung) #1729634af49401b] - test: add common.dns.errorLookupMock (Joyee Cheung) #17296bff7258535] - test: do not check TXT content in test-dns-any (Joyee Cheung) #18547daeb6de8ec] - test: use internet.addresses in internet tests (Joyee Cheung) #163907813a0de0a] - test: introduce test/common/internet.addresses (Joyee Cheung) #16390745600a0b3] - test: remove orphaned entries from status (Kyle Farnung) #18092e42ab10957] - test: add assertions for TextEncoder/Decoder (Sho Miyamoto) #18132a1b0d5da07] - test: move tmpdir to submodule of common (Rich Trott) #178565155d8e7c3] - test: update references to archived repository (Tobias Nießen) #179241043b6fd7c] - test: fix spelling in test case comments (Tobias Nießen) #18018fdb4dbc04b] - test: remove destructor from node_test_fixture (Daniel Bevenius) #18524e55e08c80e] - test: verify the shell option works properly on execFile (jvelezpo) #183840cf9d0483f] - test: add test for tls benchmarks (Anatoli Papirovski) #18489d630874250] - test: speed up parallel/test-tls-session-cache (Anna Henningsen) #18424a1fb263880] - test: fix flaky test-http-dns-error (Bryan English) #165346f3fb46541] - test: use correct size in test-stream-buffer-list (Luigi Pinca) #18239be3c8aad59] - timers: fix a bug in error handling (Anatoli Papirovski) #20497e15f57745d] - timers: allow Immediates to be unrefed (Anatoli Papirovski) #1813995c1e2d606] - tls: set servername on client side too (James M Snell) #17935d4bccccf23] - tools: add fixer for prefer-assert-iferror.js (Shobhit Chittora) #16648016a28ac08] - tools: non-Ascii linter for /lib only (Sarat Addepalli) #18043a0a45fc3b6] - tools: add .mjs linting for Windows (Vse Mozhet Byt) #18569e0d2842b29] - tools: add check for using process.binding crypto (Daniel Bevenius) #17867a8b5a96d15] - tools: auto fix custom eslint rule (Shobhit Chittora) #166525d03c8219a] - url: simplify loop in parser (Tobias Nießen) #18468e0e0ef7bab] - util: escaping object keys in util.inspect() (buji) #169868ac69c457b] - v8: add missing ',' in OpenBSD's 'sources' section. (Aaron Bieber) #18448c61754fad9] - win, build: fix intl-none option (Birunthan Mohanathas) #18292