Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Add a missing comma #19555

Closed
wants to merge 1 commit into from
Closed

doc: Add a missing comma #19555

wants to merge 1 commit into from

Conversation

leaves4j
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. dont-land-on-v4.x node-api Issues and PRs related to the Node-API. labels Mar 23, 2018
@trivikr
Copy link
Member

trivikr commented Mar 24, 2018

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/304/

@trivikr trivikr added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 24, 2018
trivikr pushed a commit that referenced this pull request Mar 24, 2018
@leaves4j @trivikr
doc: Add a missing comma
d4b3fcb 
PR-URL: #19555
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@trivikr
Copy link
Member

trivikr commented Mar 24, 2018 •
edited
Loading

Landed in d4b3fcb

@leaves4j Congratulations on your first PR and commit in Node.js core! 🎉

@trivikr trivikr closed this Mar 24, 2018
targos pushed a commit that referenced this pull request Mar 27, 2018
@leaves4j @targos
doc: Add a missing comma
9845fc3 
PR-URL: #19555
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
@leaves4j
doc: Add a missing comma
b25dec8 
PR-URL: nodejs#19555
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@leaves4j
doc: Add a missing comma
041c9a0 
PR-URL: nodejs#19555
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@leaves4j @MylesBorins
doc: Add a missing comma
71acb52 
Backport-PR-URL: #19447
PR-URL: #19555
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
@leaves4j @MylesBorins
doc: Add a missing comma
f0ba2c6 
Backport-PR-URL: #19265
PR-URL: #19555
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trivikr trivikr trivikr approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@leaves4j @trivikr @cjihrig @nodejs-github-bot