Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: show pending exception error in napi tests #18413

Closed
wants to merge 2 commits into from
Closed

test: show pending exception error in napi tests #18413

wants to merge 2 commits into from

Conversation

reccanti
Copy link
Contributor

Shows the result of the wasPending in the error message if the
assertion fails.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

@reccanti
test: show pending exception error in napi tests
82c9ef2 
Shows the result of the wasPending in the error message if the
assertion fails.
@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jan 27, 2018
Trott
Trott reviewed Jan 30, 2018
View reviewed changes
test/addons-napi/test_exception/test.js Outdated
const exception_pending = test_exception.wasPending();
assert.strictEqual(exception_pending, true,
'Expected exception to be pending, but' +
`it was marked as ${exception_pending}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change might be more confusing than helpful. Is "marked as false" going to help someone or confuse them?

How about this:

`Exception not pending as expected, .wasPending() returned ${exception_pending}`

Trott
Trott reviewed Jan 30, 2018
View reviewed changes
test/addons-napi/test_exception/test.js Outdated
const exception_pending = test_exception.wasPending();
assert.strictEqual(exception_pending, false,
'Expected no exception to be pending, but' +
` it was marked as ${exception_pending}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above, although with the text changed to reverse the expectation.

Trott
Trott requested changes Jan 30, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. It's close, I think, but I'd like to see the text improved a little bit. What do you think?

@reccanti
test: update error message for pending exceptions
1d2cc64 
Updated the error message for pending exceptions so that it was a bit
more clear.
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 31, 2018
@BridgeAR
Copy link
Member

CI https://ci.nodejs.org/job/node-test-pull-request/12832/

@reccanti
Copy link
Contributor Author

@Trott Thanks for the feedback, I wasn't quite sure what to put there. I updated the error messages. How do they look?

Trott
Trott approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the pull request!

@BridgeAR
Copy link
Member

BridgeAR commented Feb 1, 2018

Landed in 0c16b18

@BridgeAR BridgeAR closed this Feb 1, 2018
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Feb 1, 2018
@reccanti @BridgeAR
test: show pending exception error in napi tests
0c16b18 
Shows the result of the wasPending in the error message if the
assertion fails.

PR-URL: nodejs#18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 4, 2018
MylesBorins pushed a commit that referenced this pull request Feb 20, 2018
@reccanti @MylesBorins
test: show pending exception error in napi tests
bbd2ff2 
Shows the result of the wasPending in the error message if the
assertion fails.

PR-URL: #18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@reccanti @MylesBorins
test: show pending exception error in napi tests
6cf450c 
Shows the result of the wasPending in the error message if the
assertion fails.

PR-URL: #18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@reccanti @MylesBorins
test: show pending exception error in napi tests
8c9b41a 
Shows the result of the wasPending in the error message if the
assertion fails.

PR-URL: #18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 12, 2018
@reccanti
test: show pending exception error in napi tests
bf96235 
Shows the result of the wasPending in the error message if the
assertion fails.

PR-URL: nodejs#18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@reccanti
test: show pending exception error in napi tests
e57f34c 
Shows the result of the wasPending in the error message if the
assertion fails.

PR-URL: nodejs#18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@reccanti @MylesBorins
test: show pending exception error in napi tests
59249a1 
Shows the result of the wasPending in the error message if the
assertion fails.

Backport-PR-URL: #19447
PR-URL: #18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
MylesBorins pushed a commit that referenced this pull request May 1, 2018
@reccanti @MylesBorins
test: show pending exception error in napi tests
bebcdfe 
Shows the result of the wasPending in the error message if the
assertion fails.

Backport-PR-URL: #19265
PR-URL: #18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@reccanti @MayaLekova
test: show pending exception error in napi tests
1c32656 
Shows the result of the wasPending in the error message if the
assertion fails.

PR-URL: nodejs#18413
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@reccanti @BridgeAR @jasnell @Trott @addaleax @nodejs-github-bot