-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: show pending exception error in napi tests #18413
Closed
Closed
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,9 +20,10 @@ const theError = new Error('Some error'); | |
|
||
// Test that the exception thrown above was marked as pending | ||
// before it was handled on the JS side | ||
assert.strictEqual(test_exception.wasPending(), true, | ||
'VM was marked as having an exception pending' + | ||
' when it was allowed through'); | ||
const exception_pending = test_exception.wasPending(); | ||
assert.strictEqual(exception_pending, true, | ||
'Expected exception to be pending, but' + | ||
`it was marked as ${exception_pending}`); | ||
|
||
// Test that the native side does not capture a non-existing exception | ||
returnedError = test_exception.returnException(common.mustCall()); | ||
|
@@ -44,7 +45,8 @@ const theError = new Error('Some error'); | |
` ${caughtError} was passed`); | ||
|
||
// Test that the exception state remains clear when no exception is thrown | ||
assert.strictEqual(test_exception.wasPending(), false, | ||
'VM was not marked as having an exception pending' + | ||
' when none was allowed through'); | ||
const exception_pending = test_exception.wasPending(); | ||
assert.strictEqual(exception_pending, false, | ||
'Expected no exception to be pending, but' + | ||
` it was marked as ${exception_pending}`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as above, although with the text changed to reverse the expectation. |
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change might be more confusing than helpful. Is "marked as false" going to help someone or confuse them?
How about this: