Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: fix flaky test-http2-https-fallback #19093

Closed

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Mar 2, 2018

The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

This test was introduced in #18986.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2, test

The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

See: nodejs#18986
@mcollina mcollina requested review from jasnell and addaleax March 2, 2018 19:43
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 2, 2018
@mcollina mcollina added fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. labels Mar 2, 2018
@mcollina
Copy link
Member Author

mcollina commented Mar 2, 2018

@mcollina
Copy link
Member Author

mcollina commented Mar 2, 2018

@BridgeAR
Copy link
Member

BridgeAR commented Mar 2, 2018

Seems like Windows had some build issues.

New CI https://ci.nodejs.org/job/node-test-pull-request/13461/

Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@addaleax
Copy link
Member

addaleax commented Mar 2, 2018

Looks like Windows is still failing completely? /cc @nodejs/build

@joyeecheung
Copy link
Member

Windows has been fixed in #19103 , the last CI there suggested this one was the only error.

New CI: https://ci.nodejs.org/job/node-test-pull-request/13467/

@mcollina
Copy link
Member Author

mcollina commented Mar 3, 2018

Windows is failing for something else:

https://ci.nodejs.org/job/node-test-binary-windows/15421/COMPILED_BY=vs2017,RUNNER=win2016,RUN_SUBSET=0/console

not ok 531 sequential/test-inspector-stop-profile-after-done

This can land.

@mcollina
Copy link
Member Author

mcollina commented Mar 3, 2018

Landed in 153ee7f

@mcollina mcollina closed this Mar 3, 2018
@mcollina mcollina deleted the fix-flaky-http2-https-fallback-test branch March 3, 2018 12:11
mcollina added a commit that referenced this pull request Mar 3, 2018
The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

See: #18986

PR-URL: #19093
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@joyeecheung
Copy link
Member

@mcollina The hash is bbc9807

@mcollina
Copy link
Member Author

mcollina commented Mar 3, 2018

@joyeecheung Good spot!

addaleax pushed a commit to addaleax/node that referenced this pull request Mar 5, 2018
The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

See: nodejs#18986

PR-URL: nodejs#19093
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

See: nodejs#18986

PR-URL: nodejs#19093
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

See: #18986

Backport-PR-URL: #20456
PR-URL: #19093
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

See: nodejs#18986

PR-URL: nodejs#19093
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

See: #18986

Backport-PR-URL: #20456
PR-URL: #19093
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request May 15, 2018
The test was flaky because it relied on a specific order of
asynchronous operation that were fired paralellely. This was true
on most platform and conditions, but not all the time.

See: #18986

Backport-PR-URL: #20456
PR-URL: #19093
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. http2 Issues or PRs related to the http2 subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants