Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http2: remember sent headers #18045

Closed
wants to merge 1 commit into from
Closed

http2: remember sent headers #18045

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Jan 8, 2018

Add sentHeaders, sentTrailers, and sentInfoHeaders properties on Http2Stream.

Fixes: #16619

ping @mcollina

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x http2 Issues or PRs related to the http2 subsystem. labels Jan 8, 2018
mcollina
mcollina approved these changes Jan 8, 2018
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell
Copy link
Member Author

jasnell commented Jan 10, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/12491/

@jasnell
http2: remember sent headers
fae7328 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

Fixes: nodejs#16619
@jasnell
Copy link
Member Author

jasnell commented Jan 11, 2018

New CI: https://ci.nodejs.org/job/node-test-pull-request/12507/

jasnell added a commit to jasnell/node that referenced this pull request Jan 11, 2018
@jasnell
http2: remember sent headers
ee2e7fc 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

PR-URL: nodejs#18045
Fixes: nodejs#16619
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Jan 11, 2018

Landed in ee2e7fc

@jasnell jasnell closed this Jan 11, 2018
evanlucas pushed a commit that referenced this pull request Jan 30, 2018
@jasnell @evanlucas
http2: remember sent headers
eee40c7 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

PR-URL: #18045
Fixes: #16619
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@evanlucas evanlucas mentioned this pull request Jan 30, 2018
Merged
kjin pushed a commit to kjin/node that referenced this pull request May 1, 2018
@jasnell @kjin
http2: remember sent headers
1d5ab00 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

PR-URL: nodejs#18045
Fixes: nodejs#16619
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 2, 2018
@jasnell @MylesBorins
http2: remember sent headers
a4d910c 
Add sentHeaders, sentTrailers, and sentInfoHeaders properties
on `Http2Stream`.

Backport-PR-URL: #20456
PR-URL: #18045
Fixes: #16619
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasnell @mcollina @nodejs-github-bot