Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: fix meta and description #18651

Closed
wants to merge 2 commits into from
Closed

crypto: fix meta and description #18651

wants to merge 2 commits into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Feb 8, 2018

It seems like these slipped through in #8281 and #12223. Requesting reviews from authors.

Checklist
Affected core subsystem(s)

doc

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 8, 2018
@tniessen tniessen requested review from lpinca and TimothyGu February 8, 2018 18:56
@nodejs-github-bot nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Feb 8, 2018
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 8, 2018
@BridgeAR
Copy link
Member

BridgeAR commented Feb 8, 2018

@tniessen please always trigger a CI after opening a PR :-)

@BridgeAR
Copy link
Member

BridgeAR commented Feb 8, 2018

Light-CI https://ci.nodejs.org/job/node-test-commit-light/238/

tniessen added a commit that referenced this pull request Feb 9, 2018
@tniessen
doc: fix description of createDecipheriv
4927d94 
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
tniessen added a commit that referenced this pull request Feb 9, 2018
@tniessen
doc: add missing meta for createCipheriv
95a35bc 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@tniessen
Copy link
Member Author

tniessen commented Feb 9, 2018

Landed in 4927d94, 95a35bc.

@tniessen tniessen closed this Feb 9, 2018
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen @MylesBorins
doc: fix description of createDecipheriv
27d10a5 
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen @MylesBorins
doc: add missing meta for createCipheriv
1d0be7c 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen @MylesBorins
doc: fix description of createDecipheriv
d441904 
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen @MylesBorins
doc: add missing meta for createCipheriv
64aae93 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen @MylesBorins
doc: fix description of createDecipheriv
b4d04a8 
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen @MylesBorins
doc: add missing meta for createCipheriv
97b5c1f 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen @MylesBorins
doc: fix description of createDecipheriv
affddd3 
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@tniessen @MylesBorins
doc: add missing meta for createCipheriv
832e052 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@gibfahn
Copy link
Member

gibfahn commented Apr 13, 2018

95a35bc had conflicts on v6.x so I skipped it, if someone would like to backport feel free (although I don't think it's a high priority one).

gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@tniessen @gibfahn
doc: fix description of createDecipheriv
0071560 
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@tniessen @gibfahn
doc: fix description of createDecipheriv
0067bcc 
PR-URL: #18651
Refs: #12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
gibfahn pushed a commit that referenced this pull request Apr 13, 2018
@tniessen @gibfahn
doc: add missing meta for createCipheriv
f8ad381 
PR-URL: #18651
Refs: #8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 13, 2018
Merged
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@tniessen @MayaLekova
doc: fix description of createDecipheriv
b29884f 
PR-URL: nodejs#18651
Refs: nodejs#12223
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@tniessen @MayaLekova
doc: add missing meta for createCipheriv
4a73e7b 
PR-URL: nodejs#18651
Refs: nodejs#8281
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
@tniessen tniessen removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tniessen @BridgeAR @gibfahn @lpinca @TimothyGu @nodejs-github-bot