Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: add .mjs linting for Windows #18569

Closed
wants to merge 1 commit into from
Closed

tools: add .mjs linting for Windows #18569

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tools, modules

Sync Windows linting with

node/Makefile

Line 1104 in 05e702d

--rulesdir=tools/eslint-rules --ext=.js,.mjs,.md $(LINT_JS_TARGETS)

This seems to be slipped in c8a389e

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Feb 4, 2018
@vsemozhetbyt vsemozhetbyt added tools Issues and PRs related to the tools directory. fast-track PRs that do not need to wait for 48 hours to land. esm Issues and PRs related to the ECMAScript Modules implementation. labels Feb 4, 2018
@vsemozhetbyt
Copy link
Contributor Author

It seems we cannot CI-check this (we do not lint on Windows machines), but I've checked the command locally.

vsemozhetbyt added a commit that referenced this pull request Feb 4, 2018
@vsemozhetbyt
tools: add .mjs linting for Windows
9974d6a 
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@vsemozhetbyt
Copy link
Contributor Author

Landed in 9974d6a

@vsemozhetbyt vsemozhetbyt deleted the tools-win-lint-mjs branch February 4, 2018 22:33
@vsemozhetbyt vsemozhetbyt mentioned this pull request Feb 4, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
9f2b4c4 
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
9075cb1 
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Feb 21, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
aabbdc8 
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request Feb 21, 2018
Merged
@MylesBorins
Copy link
Contributor

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

@vsemozhetbyt vsemozhetbyt mentioned this pull request Mar 20, 2018
Closed
2 tasks
@vsemozhetbyt
Copy link
Contributor Author

Backport: #19496

MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
f22d276 
Backport-PR-URL: #19496
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
9f380dc 
Backport-PR-URL: #19496
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
a0a45fc 
Backport-PR-URL: #19496
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins MylesBorins mentioned this pull request May 2, 2018
Merged
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@vsemozhetbyt @MayaLekova
tools: add .mjs linting for Windows
1c9112f 
PR-URL: nodejs#18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimothyGu TimothyGu TimothyGu approved these changes

@addaleax addaleax addaleax approved these changes

@apapirovski apapirovski apapirovski approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vsemozhetbyt @MylesBorins @apapirovski @addaleax @TimothyGu @nodejs-github-bot