Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v8.x backport] tools: add .mjs linting for Windows #19496

Closed
wants to merge 1 commit into from
Closed

[v8.x backport] tools: add .mjs linting for Windows #19496

wants to merge 1 commit into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Mar 20, 2018 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Backport of #18569

It seems we cannot CI-check this (we do not lint on Windows machines), but I've checked the command locally.

@vsemozhetbyt
tools: add .mjs linting for Windows
9d6a69e 
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v8.x windows Issues and PRs related to the Windows platform. labels Mar 20, 2018
@vsemozhetbyt vsemozhetbyt mentioned this pull request Mar 20, 2018
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Mar 21, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
f22d276 
Backport-PR-URL: #19496
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@MylesBorins
Copy link
Contributor

land in f22d276

@vsemozhetbyt vsemozhetbyt deleted the backport-18569-to-v8.x branch March 21, 2018 00:33
MylesBorins pushed a commit that referenced this pull request Mar 28, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
9f380dc 
Backport-PR-URL: #19496
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Mar 30, 2018
@vsemozhetbyt @MylesBorins
tools: add .mjs linting for Windows
a0a45fc 
Backport-PR-URL: #19496
PR-URL: #18569
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vsemozhetbyt @MylesBorins @nodejs-github-bot