Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: assign missed deprecation number #19149

Closed
wants to merge 1 commit into from
Closed

util: assign missed deprecation number #19149

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Mar 5, 2018

Thanks to @ChALkeR for pointing this out.

Refs: #18415

@addaleax addaleax added util Issues and PRs related to the built-in util module. fast-track PRs that do not need to wait for 48 hours to land. labels Mar 5, 2018
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Mar 5, 2018
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed lib / src Issues and PRs related to general changes in the lib or src directory. labels Mar 5, 2018
@addaleax
Copy link
Member Author

addaleax commented Mar 5, 2018

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/221/

@addaleax
Copy link
Member Author

addaleax commented Mar 5, 2018

Landed in ae31370

@addaleax addaleax closed this Mar 5, 2018
@addaleax addaleax deleted the types-deprecation-number branch March 5, 2018 18:10
@addaleax addaleax removed fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 5, 2018
addaleax added a commit that referenced this pull request Mar 5, 2018
@addaleax
util: assign missed deprecation number
ae31370 
Refs: #18415
PR-URL: #19149
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Mar 6, 2018
Closed
4 tasks
@MylesBorins
Copy link
Contributor

Should this be backported to v9.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 1, 2018
@addaleax @BridgeAR
util: assign missed deprecation number
148210f 
Refs: nodejs#18415
PR-URL: nodejs#19149
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
@addaleax @MayaLekova
util: assign missed deprecation number
b179dad 
Refs: nodejs#18415
PR-URL: nodejs#19149
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@addaleax @MylesBorins @BridgeAR @jasnell @nodejs-github-bot