-
Notifications
You must be signed in to change notification settings - Fork 30.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add missing metadata for version properties #19568
doc: add missing metadata for version properties #19568
Conversation
By the way, should the { name: 'node',
majorVersion: 10,
minorVersion: 0,
patchVersion: 0,
prereleaseTag: '-nightly20180323b41ed29b80',
computedVersion: 655360,
sourceUrl: 'https://nodejs.org/download/nightly/v10.0.0-nightly20180323b41ed29b80/node-v10.0.0-nightly20180323b41ed29b80.tar.gz',
headersUrl: 'https://nodejs.org/download/nightly/v10.0.0-nightly20180323b41ed29b80/node-v10.0.0-nightly20180323b41ed29b80-headers.tar.gz',
libUrl: 'https://nodejs.org/download/nightly/v10.0.0-nightly20180323b41ed29b80/win-x64/node.lib',
compareVersion: [Function] } { name: 'node',
majorVersion: 10,
minorVersion: 0,
patchVersion: 0,
prereleaseTag: '-v8-canary20180323a5d696afbd',
computedVersion: 655360,
sourceUrl: 'https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180323a5d696afbd/node-v10.0.0-v8-canary20180323a5d696afbd.tar.gz',
headersUrl: 'https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180323a5d696afbd/node-v10.0.0-v8-canary20180323a5d696afbd-headers.tar.gz',
libUrl: 'https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180323a5d696afbd/win-x64/node.lib',
compareVersion: [Function] } |
@vsemozhetbyt It probably should... Not happy about it though 😄 |
There is still a ongoing discussion in #19438. I guess we might want to wait to land this until it is decided how to handle the situation there? |
@BridgeAR Sure, as I said, I will gladly adapt this PR once we resolve the problem over there. I believe that |
#19438 did not update the metadata within the documentation.
Side note: I am not sure whether the
computedVersion
property was exposed intentionally, and would gladly update the PR if we decide not to do so.Checklist