Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing metadata for version properties #19568

Closed

Conversation

tniessen
Copy link
Member

#19438 did not update the metadata within the documentation.

Side note: I am not sure whether the computedVersion property was exposed intentionally, and would gladly update the PR if we decide not to do so.

Checklist

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Mar 24, 2018
@vsemozhetbyt
Copy link
Contributor

By the way, should the compareVersion be exposed in process.release output? Currently it is, in contradistinction to doc example:

{ name: 'node',
  majorVersion: 10,
  minorVersion: 0,
  patchVersion: 0,
  prereleaseTag: '-nightly20180323b41ed29b80',
  computedVersion: 655360,
  sourceUrl: 'https://nodejs.org/download/nightly/v10.0.0-nightly20180323b41ed29b80/node-v10.0.0-nightly20180323b41ed29b80.tar.gz',
  headersUrl: 'https://nodejs.org/download/nightly/v10.0.0-nightly20180323b41ed29b80/node-v10.0.0-nightly20180323b41ed29b80-headers.tar.gz',
  libUrl: 'https://nodejs.org/download/nightly/v10.0.0-nightly20180323b41ed29b80/win-x64/node.lib',
  compareVersion: [Function] }
{ name: 'node',
  majorVersion: 10,
  minorVersion: 0,
  patchVersion: 0,
  prereleaseTag: '-v8-canary20180323a5d696afbd',
  computedVersion: 655360,
  sourceUrl: 'https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180323a5d696afbd/node-v10.0.0-v8-canary20180323a5d696afbd.tar.gz',
  headersUrl: 'https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180323a5d696afbd/node-v10.0.0-v8-canary20180323a5d696afbd-headers.tar.gz',
  libUrl: 'https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180323a5d696afbd/win-x64/node.lib',
  compareVersion: [Function] }

@vsemozhetbyt
Copy link
Contributor

@tniessen
Copy link
Member Author

@vsemozhetbyt It probably should... Not happy about it though 😄

@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 24, 2018
@BridgeAR
Copy link
Member

There is still a ongoing discussion in #19438. I guess we might want to wait to land this until it is decided how to handle the situation there?

@tniessen
Copy link
Member Author

@BridgeAR Sure, as I said, I will gladly adapt this PR once we resolve the problem over there. I believe that process.release.majorVersion etc. are mostly uncontroversial, so this change should be at least partially valid.

@tniessen tniessen added blocked PRs that are blocked by other issues or PRs. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 24, 2018
@tniessen
Copy link
Member Author

#19577 reverts #19438 due to larger issues with that PR.

@tniessen tniessen closed this Mar 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants